mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-04-27 06:48:49 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb/HTML: Halt navigation if navigate event returns false

Browse source
This commit is contained in:
Sam Atkins 2025-01-07 16:08:19 +00:00 • committed by Andreas Kling
parent f11347739a
commit 03024765e9
Notes: github-actions[bot] 2025-01-11 10:11:36 +00:00
1 changed files with 18 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

25
Libraries/LibWeb/HTML/Navigable.cpp
View file

@ -1430,14 +1430,25 @@ WebIDL::ExceptionOr<void> Navigable::navigate(NavigateParams params)
// otherwise, StructuredSerializeForStorage(undefined).
auto navigation_api_state_for_firing = navigation_api_state.value_or(MUST(structured_serialize_for_storage(vm, JS::js_undefined())));
// FIXME: 4. Let continue be the result of firing a push/replace/reload navigate event at navigation
// with navigationType set to historyHandling, isSameDocument set to false, userInvolvement set to userInvolvement,
// formDataEntryList set to entryListForFiring, destinationURL set to url, and navigationAPIState set to navigationAPIStateForFiring.
(void)navigation;
(void)entry_list_for_firing;
(void)navigation_api_state_for_firing;
// 4. Let continue be the result of firing a push/replace/reload navigate event at navigation
// with navigationType set to historyHandling, isSameDocument set to false, userInvolvement set to userInvolvement,
// formDataEntryList set to entryListForFiring, destinationURL set to url, and navigationAPIState set to navigationAPIStateForFiring.
auto navigation_type = [](Bindings::NavigationHistoryBehavior history_handling) {
switch (history_handling) {
case Bindings::NavigationHistoryBehavior::Push:
return Bindings::NavigationType::Push;
case Bindings::NavigationHistoryBehavior::Replace:
return Bindings::NavigationType::Replace;
case Bindings::NavigationHistoryBehavior::Auto:
default:
VERIFY_NOT_REACHED();
}
}(history_handling);
auto continue_ = navigation->fire_a_push_replace_reload_navigate_event(navigation_type, url, false, user_involvement, entry_list_for_firing, navigation_api_state_for_firing);
// FIXME: 5. If continue is false, then return.
// 5. If continue is false, then return.
if (!continue_)
return {};
}
// AD-HOC: Tell the UI that we started loading.