mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-28 19:59:17 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb: Remove non-spec condition in scrollable overflow calculation

Browse source
This commit is contained in:
Psychpsyo 2024-11-23 14:58:32 +01:00 • committed by Sam Atkins
commit 0320494c3f
Notes: github-actions[bot] 2024-12-04 17:26:30 +00:00
3 changed files with 26 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Libraries/LibWeb/Layout/LayoutState.cpp
View file

@ -124,11 +124,11 @@ static CSSPixelRect measure_scrollable_overflow(Box const& box)
// (including zero-area boxes and accounting for transforms as described above), // (including zero-area boxes and accounting for transforms as described above),
// provided they themselves have overflow: visible (i.e. do not themselves trap the overflow) // provided they themselves have overflow: visible (i.e. do not themselves trap the overflow)
// and that scrollable overflow is not already clipped (e.g. by the clip property or the contain property). // and that scrollable overflow is not already clipped (e.g. by the clip property or the contain property).
if (is<Viewport>(box) || child.computed_values().overflow_x() == CSS::Overflow::Visible || child.computed_values().overflow_y() == CSS::Overflow::Visible) { if (child.computed_values().overflow_x() == CSS::Overflow::Visible || child.computed_values().overflow_y() == CSS::Overflow::Visible) {
auto child_scrollable_overflow = measure_scrollable_overflow(child); auto child_scrollable_overflow = measure_scrollable_overflow(child);
if (is<Viewport>(box) || child.computed_values().overflow_x() == CSS::Overflow::Visible) if (child.computed_values().overflow_x() == CSS::Overflow::Visible)
scrollable_overflow_rect.unite_horizontally(child_scrollable_overflow); scrollable_overflow_rect.unite_horizontally(child_scrollable_overflow);
if (is<Viewport>(box) || child.computed_values().overflow_y() == CSS::Overflow::Visible) if (child.computed_values().overflow_y() == CSS::Overflow::Visible)
scrollable_overflow_rect.unite_vertically(child_scrollable_overflow); scrollable_overflow_rect.unite_vertically(child_scrollable_overflow);
} }

1
Tests/LibWeb/Ref/expected/scrollable-overflow-viewport-bug.html Normal file
View file

@ -0,0 +1 @@
<!-- This page intentionally left blank -->

22
Tests/LibWeb/Ref/input/scrollable-overflow-viewport-bug.html Normal file
View file

@ -0,0 +1,22 @@
<!DOCTYPE html>
<link rel="match" href="../expected/scrollable-overflow-viewport-bug.html">
<style>
#child {
position: absolute;
top: 150vh;
width: 100px;
height: 100px;
}
#holder {
position: absolute;
overflow: hidden;
}
</style>
<div id="holder"></div>
<script>
const child = document.createElement("div");
child.id = "child";
holder.appendChild(child);
</script>