mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-04-27 06:48:49 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb/CSS: Leave calc() in transformations unresolved for longer

Browse source 
We don't need to resolve these at this point, and we already don't do so
for lengths, so leave them in their calc() form until they're used.
This commit is contained in:
Sam Atkins 2025-01-21 16:15:58 +00:00 • committed by Jelle Raaijmakers
parent db2e879839
commit 0321d1392c
Notes: github-actions[bot] 2025-01-24 12:57:28 +00:00
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Libraries/LibWeb/CSS/StyleValues/TransformationStyleValue.cpp
View file

@ -31,14 +31,14 @@ Transformation TransformationStyleValue::to_transformation() const
} else if (calculated.resolves_to_percentage()) {
// FIXME: Maybe transform this for loop to always check the metadata for the correct types
if (function_metadata.parameters[argument_index].type == TransformFunctionParameterType::NumberPercentage) {
values.append(NumberPercentage { calculated.resolve_percentage().value() });
values.append(NumberPercentage { calculated });
} else {
values.append(LengthPercentage { calculated.resolve_percentage().value() });
values.append(LengthPercentage { calculated });
}
} else if (calculated.resolves_to_number()) {
values.append({ Number(Number::Type::Number, calculated.resolve_number().value()) });
values.append(NumberPercentage { calculated });
} else if (calculated.resolves_to_angle()) {
values.append({ calculated.resolve_angle().value() });
values.append(AngleOrCalculated { calculated });
} else {
dbgln("FIXME: Unsupported calc value in transform! {}", calculated.to_string(SerializationMode::Normal));
}