Meta: Add a check to ensure grep -P stays gone

grep -P does not work on macOS, but grep -E does.
Author: https://github.com/thislooksfun Commit: 03494ed6ba Pull-request: https://github.com/SerenityOS/serenity/pull/10652 Reviewed-by: https://github.com/BenWiederhake ✅
2025-08-07 00:29:15 +00:00 · 2021-10-29 03:27:29 -05:00 · 2021-10-29 03:27:29 -05:00 · 03494ed6ba · 2024-07-18 01:36:47 +09:00
commit 03494ed6ba
parent a984545a94
1 changed files with 9 additions and 0 deletions
--- a/Meta/lint-shell-scripts.sh
+++ b/Meta/lint-shell-scripts.sh
@ -30,6 +30,15 @@ if (( ${#files[@]} )); then
    fi

    shellcheck "${files[@]}"
+
+    for file in "${files[@]}"; do
+        if (< "$file" grep -qE "grep [^|);]*-[^- ]*P"); then
+            # '\x2D' is the unicode escape sequence for '-'. This is used so
+            # that this script does not flag itself for containing grep dash P.
+            echo -e "The script '$file' contains 'grep \x2DP', which is not supported on macOS. Please use grep -E instead."
+            exit 1
+        fi
+    done
 else
    echo "No .sh files to check."
 fi