LibWeb: Make value_id_from_string() return Optional

This commit is contained in:
Sam Atkins 2023-05-10 12:43:29 +01:00 committed by Andreas Kling
commit 03613dc14d
Notes: sideshowbarker 2024-07-16 23:23:26 +09:00
3 changed files with 16 additions and 17 deletions

View file

@ -67,7 +67,7 @@ enum class ValueID {
generator.append(R"~~~(
};
ValueID value_id_from_string(StringView);
Optional<ValueID> value_id_from_string(StringView);
StringView string_from_value_id(ValueID);
}
@ -105,10 +105,9 @@ HashMap<StringView, ValueID, AK::CaseInsensitiveASCIIStringViewTraits> g_stringv
generator.append(R"~~~(
};
ValueID value_id_from_string(StringView string)
Optional<ValueID> value_id_from_string(StringView string)
{
auto maybe_value_id = g_stringview_to_value_id_map.get(string);
return maybe_value_id.value_or(ValueID::Invalid);
return g_stringview_to_value_id_map.get(string);
}
StringView string_from_value_id(ValueID value_id) {