mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-04-22 20:45:14 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb: PlatformObject::DefineOwnProperty fix 'has own property' check

Browse source 
PlatformObjects with named properties does not qualify as 'has own
property' just by virtue of a named property existing.

This fixes at least one WPT test, which is imported.
This commit is contained in:
Tyler Dence 2024-12-03 02:09:57 -05:00 • committed by Jelle Raaijmakers
parent 9585700876
commit 0378645c25
Notes: github-actions[bot] 2024-12-20 14:11:20 +00:00
5 changed files with 172 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibWeb/Bindings/PlatformObject.cpp
View file

@ -296,7 +296,7 @@ JS::ThrowCompletionOr<bool> PlatformObject::internal_define_own_property(JS::Pro
precomputed_get_own_property = &get_own_property_result;
}
}
if (m_legacy_platform_object_flags->has_legacy_override_built_ins_interface_extended_attribute || precomputed_get_own_property->has_value()) {
if (m_legacy_platform_object_flags->has_legacy_override_built_ins_interface_extended_attribute || !precomputed_get_own_property->has_value()) {
// 1. If creating is false and O does not implement an interface with a named property setter, then return false.
if (!creating && !m_legacy_platform_object_flags->has_named_property_setter)
return false;

2
Tests/LibWeb/Text/expected/htmlcollection-property-set-existing.txt Normal file
View file

@ -0,0 +1,2 @@
[Pass] Object.defineProperty(HTMLCollection, key, value) throws
[Pass] "use strict"; HTMLCollection[key] setter throws

11
Tests/LibWeb/Text/expected/wpt-import/dom/collections/HTMLCollection-supported-property-names.txt Normal file
View file

@ -0,0 +1,11 @@
Harness status: OK
Found 6 tests
6 Pass
Pass Object.getOwnPropertyNames on HTMLCollection
Pass Object.getOwnPropertyNames on HTMLCollection with non-HTML namespace
Pass Object.getOwnPropertyNames on HTMLCollection with expando object
Pass Trying to set an expando that would shadow an already-existing named property
Pass Trying to set an expando that shadows a named property that gets added later
Pass Trying to set a non-configurable expando that shadows a named property that gets added later

23
Tests/LibWeb/Text/input/htmlcollection-property-set-existing.html Normal file
View file

@ -0,0 +1,23 @@
<!DOCTYPE html>
<body>
<span id=test></span>
</body>
<script src="include.js"></script>
<script>
test(() => {
var elements = document.getElementsByTagName("span");
try {
Object.defineProperty(elements, 'test', { value: 5 });
println("[Fail] Object.defineProperty(HTMLCollection, key, value) succeeds");
} catch (e) {
println("[Pass] Object.defineProperty(HTMLCollection, key, value) throws");
}
try {
(function() { "use strict"; elements['test'] = 5; })();
println("[Fail] \"use strict\"; HTMLCollection[key] setter succeeds");
} catch (e) {
println("[Pass] \"use strict\"; HTMLCollection[key] setter throws");
}
});
</script>

135
Tests/LibWeb/Text/input/wpt-import/dom/collections/HTMLCollection-supported-property-names.html Normal file
View file

@ -0,0 +1,135 @@
<!doctype html>
<meta charset=utf-8>
<link rel=help href=https://dom.spec.whatwg.org/#interface-htmlcollection>
<script src=../../resources/testharness.js></script>
<script src=../../resources/testharnessreport.js></script>
<div id=log></div>
<!-- with no attribute -->
<span></span>
<!-- with `id` attribute -->
<span id=''></span>
<span id='some-id'></span>
<span id='some-id'></span><!-- to ensure no duplicates -->
<!-- with `name` attribute -->
<span name=''></span>
<span name='some-name'></span>
<span name='some-name'></span><!-- to ensure no duplicates -->
<!-- with `name` and `id` attribute -->
<span id='another-id' name='another-name'></span>
<script>
test(function () {
var elements = document.getElementsByTagName("span");
assert_array_equals(
Object.getOwnPropertyNames(elements),
['0', '1', '2', '3', '4', '5', '6', '7', 'some-id', 'some-name', 'another-id', 'another-name']
);
}, 'Object.getOwnPropertyNames on HTMLCollection');
test(function () {
var elem = document.createElementNS('some-random-namespace', 'foo');
this.add_cleanup(function () {elem.remove();});
elem.setAttribute("name", "some-name");
document.body.appendChild(elem);
var elements = document.getElementsByTagName("foo");
assert_array_equals(Object.getOwnPropertyNames(elements), ['0']);
}, 'Object.getOwnPropertyNames on HTMLCollection with non-HTML namespace');
test(function () {
var elem = document.createElement('foo');
this.add_cleanup(function () {elem.remove();});
document.body.appendChild(elem);
var elements = document.getElementsByTagName("foo");
elements.someProperty = "some value";
assert_array_equals(Object.getOwnPropertyNames(elements), ['0', 'someProperty']);
}, 'Object.getOwnPropertyNames on HTMLCollection with expando object');
test(function() {
var elements = document.getElementsByTagName("span");
var old_item = elements["some-id"];
var old_desc = Object.getOwnPropertyDescriptor(elements, "some-id");
assert_equals(old_desc.value, old_item);
assert_false(old_desc.enumerable);
assert_true(old_desc.configurable);
assert_false(old_desc.writable);
elements["some-id"] = 5;
assert_equals(elements["some-id"], old_item);
assert_throws_js(TypeError, function() {
"use strict";
elements["some-id"] = 5;
});
assert_throws_js(TypeError, function() {
Object.defineProperty(elements, "some-id", { value: 5 });
});
delete elements["some-id"];
assert_equals(elements["some-id"], old_item);
assert_throws_js(TypeError, function() {
"use strict";
delete elements["some-id"];
});
assert_equals(elements["some-id"], old_item);
}, 'Trying to set an expando that would shadow an already-existing named property');
test(function() {
var elements = document.getElementsByTagName("span");
var old_item = elements["new-id"];
var old_desc = Object.getOwnPropertyDescriptor(elements, "new-id");
assert_equals(old_item, undefined);
assert_equals(old_desc, undefined);
elements["new-id"] = 5;
assert_equals(elements["new-id"], 5);
var span = document.createElement("span");
this.add_cleanup(function () {span.remove();});
span.id = "new-id";
document.body.appendChild(span);
assert_equals(elements.namedItem("new-id"), span);
assert_equals(elements["new-id"], 5);
delete elements["new-id"];
assert_equals(elements["new-id"], span);
}, 'Trying to set an expando that shadows a named property that gets added later');
test(function() {
var elements = document.getElementsByTagName("span");
var old_item = elements["new-id2"];
var old_desc = Object.getOwnPropertyDescriptor(elements, "new-id2");
assert_equals(old_item, undefined);
assert_equals(old_desc, undefined);
Object.defineProperty(elements, "new-id2", { configurable: false, writable:
false, value: 5 });
assert_equals(elements["new-id2"], 5);
var span = document.createElement("span");
this.add_cleanup(function () {span.remove();});
span.id = "new-id2";
document.body.appendChild(span);
assert_equals(elements.namedItem("new-id2"), span);
assert_equals(elements["new-id2"], 5);
delete elements["new-id2"];
assert_equals(elements["new-id2"], 5);
assert_throws_js(TypeError, function() {
"use strict";
delete elements["new-id2"];
});
assert_equals(elements["new-id2"], 5);
}, 'Trying to set a non-configurable expando that shadows a named property that gets added later');
</script>