From 0427646883a72787591096ef05b4c7ae1797deb3 Mon Sep 17 00:00:00 2001 From: Andrew Kaster Date: Mon, 9 Sep 2024 13:19:54 -0600 Subject: [PATCH] Meta: Remove check-ak-test-files script This script only checks Tests/AK, and verifies that all source files that match Tests/AK/*.cpp are listed in the CMakeLists.txt. This is a bit excessive. We don't have this check for any other test files. This sort of error will definitely :tm: be caught in review. --- Meta/check-ak-test-files.sh | 25 ------------------------- Meta/lint-ci.sh | 1 - 2 files changed, 26 deletions(-) delete mode 100755 Meta/check-ak-test-files.sh diff --git a/Meta/check-ak-test-files.sh b/Meta/check-ak-test-files.sh deleted file mode 100755 index 564c34ceb9e..00000000000 --- a/Meta/check-ak-test-files.sh +++ /dev/null @@ -1,25 +0,0 @@ -#!/usr/bin/env bash - -set -eo pipefail - -script_path=$(cd -P -- "$(dirname -- "$0")" && pwd -P) -cd "${script_path}/.." - -MISSING_FILES=n - -while IFS= read -r FILENAME; do - # Simply search whether the CMakeLists.txt *ever* mention the test files. - if ! grep -qF "${FILENAME}" Tests/AK/CMakeLists.txt ; then - echo "Tests/AK/CMakeLists.txt is either missing the test file ${FILENAME} or is not in the commit's staged changes" - MISSING_FILES=y - fi -done < <( - git ls-files 'Tests/AK/Test*.cpp' | xargs -n1 basename -) - -if [ "n" != "${MISSING_FILES}" ] ; then - echo "Some files are missing from the Tests/AK/CMakeLists.txt." - echo "If a new test file is being added, ensure it is in the CMakeLists.txt." - echo "This ensures the new tests are always run." - exit 1 -fi diff --git a/Meta/lint-ci.sh b/Meta/lint-ci.sh index 78f69b4f35e..8bde2beff5f 100755 --- a/Meta/lint-ci.sh +++ b/Meta/lint-ci.sh @@ -14,7 +14,6 @@ FAILURES=0 set +e for cmd in \ - Meta/check-ak-test-files.sh \ Meta/check-debug-flags.sh \ Meta/check-newlines-at-eof.py \ Meta/check-png-sizes.sh \