mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-10-16 13:09:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb/CSS: Use LengthPercentageOrAuto for background sizes

Browse source 
...instead of `auto` Lengths.

This also fixes interpolating between two `auto` `<bg-size>`s, which
fixes a lot of animation tests for both `background-size` and `mask`.
This commit is contained in:
Sam Atkins 2025-08-28 13:02:52 +01:00
commit 04622f3940
Notes: github-actions[bot] 2025-09-04 12:33:16 +00:00
8 changed files with 218 additions and 201 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Libraries/LibWeb/CSS/Parser/PropertyParsing.cpp
View file

@ -1477,9 +1477,9 @@ RefPtr<StyleValue const> Parser::parse_single_background_size_value(PropertyID p
{
auto transaction = tokens.begin_transaction();
auto get_length_percentage = [](StyleValue const& style_value) -> Optional<LengthPercentage> {
auto get_length_percentage_or_auto = [](StyleValue const& style_value) -> Optional<LengthPercentageOrAuto> {
if (style_value.has_auto())
return LengthPercentage { Length::make_auto() };
return LengthPercentageOrAuto::make_auto();
if (style_value.is_percentage())
return LengthPercentage { style_value.as_percentage().percentage() };
if (style_value.is_length())
@ -1501,8 +1501,8 @@ RefPtr<StyleValue const> Parser::parse_single_background_size_value(PropertyID p
auto maybe_y_value = parse_css_value_for_property(property, tokens);
if (!maybe_y_value) {
auto y_value = LengthPercentage { Length::make_auto() };
auto x_size = get_length_percentage(*x_value);
auto y_value = LengthPercentageOrAuto::make_auto();
auto x_size = get_length_percentage_or_auto(*x_value);
if (!x_size.has_value())
return nullptr;
@ -1511,8 +1511,8 @@ RefPtr<StyleValue const> Parser::parse_single_background_size_value(PropertyID p
}
auto y_value = maybe_y_value.release_nonnull();
auto x_size = get_length_percentage(*x_value);
auto y_size = get_length_percentage(*y_value);
auto x_size = get_length_percentage_or_auto(*x_value);
auto y_size = get_length_percentage_or_auto(*y_value);
if (!x_size.has_value() || !y_size.has_value())
return nullptr;