mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-10-16 04:59:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb/CSS: Use LengthPercentageOrAuto for background sizes

Browse source 
...instead of `auto` Lengths.

This also fixes interpolating between two `auto` `<bg-size>`s, which
fixes a lot of animation tests for both `background-size` and `mask`.
This commit is contained in:
Sam Atkins 2025-08-28 13:02:52 +01:00
commit 04622f3940
Notes: github-actions[bot] 2025-09-04 12:33:16 +00:00
8 changed files with 218 additions and 201 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Libraries/LibWeb/CSS/StyleValues/BackgroundSizeStyleValue.cpp
View file

@ -11,7 +11,7 @@
namespace Web::CSS {
BackgroundSizeStyleValue::BackgroundSizeStyleValue(LengthPercentage size_x, LengthPercentage size_y)
BackgroundSizeStyleValue::BackgroundSizeStyleValue(LengthPercentageOrAuto size_x, LengthPercentageOrAuto size_y)
: StyleValueWithDefaultOperators(Type::BackgroundSize)
, m_properties { .size_x = move(size_x), .size_y = move(size_y) }
{
@ -28,8 +28,14 @@ String BackgroundSizeStyleValue::to_string(SerializationMode mode) const
ValueComparingNonnullRefPtr<StyleValue const> BackgroundSizeStyleValue::absolutized(CSSPixelRect const& viewport_rect, Length::FontMetrics const& font_metrics, Length::FontMetrics const& root_font_metrics) const
{
auto absolutized_size_x = m_properties.size_x.absolutized(viewport_rect, font_metrics, root_font_metrics);
auto absolutized_size_y = m_properties.size_y.absolutized(viewport_rect, font_metrics, root_font_metrics);
auto absolutize = [&](auto& size) -> LengthPercentageOrAuto {
if (size.is_auto())
return size;
return size.length_percentage().absolutized(viewport_rect, font_metrics, root_font_metrics);
};
auto absolutized_size_x = absolutize(m_properties.size_x);
auto absolutized_size_y = absolutize(m_properties.size_y);
if (absolutized_size_x == m_properties.size_x && absolutized_size_y == m_properties.size_y)
return *this;