mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-09-07 10:06:03 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Add methods to Document that must do nothing

Browse source 
This change adds the `clear()`, `captureEvents()` and `releaseEvents()`
methods to the document object. These methods are obsolete, but are
still included in the HTML specification, which says they must do
nothing.
This commit is contained in:
Tim Ledbetter 2024-04-14 07:25:49 +01:00 • committed by Andreas Kling
commit 0564e06f10
Notes: sideshowbarker 2024-07-18 05:37:06 +09:00
5 changed files with 38 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Tests/LibWeb/Text/expected/DOM/Document-methods-that-must-do-nothing.txt Normal file
View file

@ -0,0 +1,3 @@
document.clear() returns undefined: true
document.captureEvents() returns undefined: true
document.releaseEvents() returns undefined: true

9
Tests/LibWeb/Text/input/DOM/Document-methods-that-must-do-nothing.html Normal file
View file

@ -0,0 +1,9 @@
<!DOCTYPE html>
<script src="../include.js"></script>
<script>
test(() => {
println(`document.clear() returns undefined: ${document.clear() === undefined}`);
println(`document.captureEvents() returns undefined: ${document.captureEvents() === undefined}`);
println(`document.releaseEvents() returns undefined: ${document.releaseEvents() === undefined}`);
});
</script>

18
Userland/Libraries/LibWeb/DOM/Document.cpp
View file

@ -1472,6 +1472,24 @@ JS::NonnullGCPtr<HTML::HTMLAllCollection> Document::all()
return *m_all;
}
// https://html.spec.whatwg.org/multipage/obsolete.html#dom-document-clear
void Document::clear()
{
// Do nothing
}
// https://html.spec.whatwg.org/multipage/obsolete.html#dom-document-captureevents
void Document::capture_events()
{
// Do nothing
}
// https://html.spec.whatwg.org/multipage/obsolete.html#dom-document-releaseevents
void Document::release_events()
{
// Do nothing
}
Color Document::link_color() const
{
if (m_link_color.has_value())

4
Userland/Libraries/LibWeb/DOM/Document.h
View file

@ -243,6 +243,10 @@ public:
JS::NonnullGCPtr<HTMLCollection> scripts();
JS::NonnullGCPtr<HTML::HTMLAllCollection> all();
void clear();
void capture_events();
void release_events();
String const& source() const { return m_source; }
void set_source(String source) { m_source = move(source); }

4
Userland/Libraries/LibWeb/DOM/Document.idl
View file

@ -78,6 +78,10 @@ interface Document : Node {
readonly attribute HTMLAllCollection all;
undefined clear();
undefined captureEvents();
undefined releaseEvents();
[CEReactions, NewObject] Element createElement(DOMString tagName, optional (DOMString or ElementCreationOptions) options = {});
[CEReactions, NewObject] Element createElementNS([FlyString] DOMString? namespace, DOMString qualifiedName, optional (DOMString or ElementCreationOptions) options = {});
DocumentFragment createDocumentFragment();