mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-24 18:02:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Don't assume length-percentage is always a length [GFC]

Browse source 
Fixes crashing when trying to get length from LengthPercentage with
percentage value.
This commit is contained in:
Aliaksandr Kalenik 2025-03-24 13:52:55 +00:00 • committed by Jelle Raaijmakers
parent 685cc1aae8
commit 057e643a63
Notes: github-actions[bot] 2025-03-24 18:00:19 +00:00
3 changed files with 14 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibWeb/Layout/GridFormattingContext.cpp
View file

@ -2563,7 +2563,7 @@ CSSPixels GridFormattingContext::content_based_minimum_size(GridItem const& item
spans_only_tracks_with_limited_max_track_sizing_function = false;
break;
}
sum_of_max_sizing_functions += track.max_track_sizing_function.length_percentage().length().to_px(item.box);
sum_of_max_sizing_functions += track.max_track_sizing_function.length_percentage().to_px(item.box, m_available_space->width.to_px_or_zero());
}
if (spans_only_tracks_with_limited_max_track_sizing_function) {
result = min(result, sum_of_max_sizing_functions);

7
Tests/LibWeb/Layout/expected/grid/minmax-with-percentage-max.txt Normal file
View file

@ -0,0 +1,7 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
Box <html> at (0,0) content-size 800x16 [GFC] children: not-inline
BlockContainer <body> at (8,8) content-size 184x0 [BFC] children: not-inline
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableBox (Box<HTML>) [0,0 800x16]
PaintableWithLines (BlockContainer<BODY>) [8,8 184x0]

6
Tests/LibWeb/Layout/input/grid/minmax-with-percentage-max.html Normal file
View file

@ -0,0 +1,6 @@
<!doctype html><style>
html {
display: grid;
grid-template-columns: minmax(auto, 25%);
}
</style>