mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-08 09:09:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Space-separate parts of multi-label accessible names

Browse source 
This change ensures that when an accessible name is computed from
multiple labels, the parts computed from each label are separated by
spaces. Otherwise, without this change, the parts are run together in
the accessible name, with no space in between.
This commit is contained in:
sideshowbarker 2024-12-26 13:47:41 +09:00 • committed by Tim Ledbetter
commit 062e33438e
Notes: github-actions[bot] 2024-12-26 20:45:13 +00:00
3 changed files with 11 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibWeb/DOM/Node.cpp
View file

@ -2425,6 +2425,8 @@ ErrorOr<String> Node::name_or_description(NameOrDescription target, Document con
if (labels != nullptr && labels->length() > 0) {
StringBuilder builder;
for (u32 i = 0; i < labels->length(); i++) {
if (!builder.is_empty())
builder.append(" "sv);
auto nodes = labels->item(i)->children_as_vector();
for (auto const& node : nodes) {
// AD-HOC: https://wpt.fyi/results/accname/name/comp_host_language_label.html has “encapsulation”

7
Tests/LibWeb/Text/expected/wpt-import/accname/name/comp_host_language_label.txt
View file

@ -1,8 +1,8 @@
Harness status: OK
Found 78 tests
Found 79 tests
78 Pass
79 Pass
Pass html: input[type=button]
Pass html: input[type=image]
Pass html: input[type=reset]
@ -80,4 +80,5 @@ Pass html: select encapsulation
Pass html: img[alt] (non-empty)
Pass html: picture > img[alt] (non-empty)
Pass html: fieldset > legend
Pass html: table > caption
Pass html: table > caption
Pass html: multiple label elements[for]

5
Tests/LibWeb/Text/input/wpt-import/accname/name/comp_host_language_label.html
View file

@ -155,6 +155,11 @@
<tr><th>a</th><th>b</th><th>c</th></tr>
<tr><th>1</th><td>2</td><td>3</td></tr>
</table>
<!-- HTML-AAM: https://www.w3.org/TR/html-aam-1.0/#input-type-text-input-type-password-input-type-number-input-type-search-input-type-tel-input-type-email-input-type-url-and-textarea-element-accessible-name-computation -->
<h2>HTML input with multiple label/for</h2>
<label for="multi-label">textfield label 1</label>
<label for="multi-label">textfield label 2</label>
<input id="multi-label" type="text" data-expectedlabel="textfield label 1 textfield label 2" data-testname="html: multiple label elements[for]" class="ex">
<!-- SVG: -> /svg-aam/name/ -->
<!-- todo: Ruby? -->
<!-- todo: MathML? -->