mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-10-16 04:59:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb/CSS: Allow converting CSSMathValues to StyleValues

Browse source 
Because we store calculations as a tree of CalculationNodes inside a
CalculatedStyleValue, instead of a tree of StyleValues directly, this
implements a create_calculation_node() method on CSSNumericValue.
CSSMathValue::create_an_internal_representation() then calls
create_calculation_node() on itself, and wraps it in a
CalculatedStyleValue.

Lots of WPT passes again! Some regressions, which are expected: `cursor`
fails a test for the same reason it fails other that set it to some
kind of numeric value: We don't distinguish between "can contain a
number" and "can accept a number by itself". This will affect any
similar properties, but overall this is a big improvement.
This commit is contained in:
Sam Atkins 2025-10-10 17:29:54 +01:00
commit 078bc1a471
Notes: github-actions[bot] 2025-10-13 09:01:05 +00:00
24 changed files with 172 additions and 36 deletions
Download patch file Download diff file Expand all files Collapse all files

42
Libraries/LibWeb/CSS/CSSMathValue.cpp
View file

@ -6,6 +6,8 @@
#include "CSSMathValue.h"
#include <LibWeb/Bindings/Intrinsics.h>
#include <LibWeb/CSS/PropertyNameAndID.h>
#include <LibWeb/CSS/StyleValues/CalculatedStyleValue.h>
namespace Web::CSS {
@ -23,4 +25,44 @@ void CSSMathValue::initialize(JS::Realm& realm)
Base::initialize(realm);
}
// https://drafts.css-houdini.org/css-typed-om-1/#create-an-internal-representation
WebIDL::ExceptionOr<NonnullRefPtr<StyleValue const>> CSSMathValue::create_an_internal_representation(PropertyNameAndID const& property) const
{
// If value is a CSSStyleValue subclass,
// If value does not match the grammar of a list-valued property iteration of property, throw a TypeError.
//
// If any component of property’s CSS grammar has a limited numeric range, and the corresponding part of value
// is a CSSUnitValue that is outside of that range, replace that value with the result of wrapping it in a
// fresh CSSMathSum whose values internal slot contains only that part of value.
//
// Return the value.
// FIXME: Check types allowed by registered custom properties.
auto context = CalculationContext::for_property(property);
auto matches = [&] {
if (type().matches_angle(context.percentages_resolve_as))
return property_accepts_type(property.id(), ValueType::Angle);
if (type().matches_flex(context.percentages_resolve_as))
return property_accepts_type(property.id(), ValueType::Flex);
if (type().matches_frequency(context.percentages_resolve_as))
return property_accepts_type(property.id(), ValueType::Frequency);
if (type().matches_length(context.percentages_resolve_as))
return property_accepts_type(property.id(), ValueType::Length);
if (type().matches_number(context.percentages_resolve_as))
return property_accepts_type(property.id(), ValueType::Number);
if (type().matches_percentage())
return property_accepts_type(property.id(), ValueType::Percentage);
if (type().matches_resolution(context.percentages_resolve_as))
return property_accepts_type(property.id(), ValueType::Resolution);
if (type().matches_time(context.percentages_resolve_as))
return property_accepts_type(property.id(), ValueType::Time);
return false;
}();
if (!matches)
return WebIDL::SimpleException { WebIDL::SimpleExceptionType::TypeError, "Property does not accept values of this type."sv };
return CalculatedStyleValue::create(TRY(create_calculation_node(context)), type(), move(context));
}
}