mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-10-17 05:29:56 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb/CSS: Allow converting CSSMathValues to StyleValues

Browse source 
Because we store calculations as a tree of CalculationNodes inside a
CalculatedStyleValue, instead of a tree of StyleValues directly, this
implements a create_calculation_node() method on CSSNumericValue.
CSSMathValue::create_an_internal_representation() then calls
create_calculation_node() on itself, and wraps it in a
CalculatedStyleValue.

Lots of WPT passes again! Some regressions, which are expected: `cursor`
fails a test for the same reason it fails other that set it to some
kind of numeric value: We don't distinguish between "can contain a
number" and "can accept a number by itself". This will affect any
similar properties, but overall this is a big improvement.
This commit is contained in:
Sam Atkins 2025-10-10 17:29:54 +01:00
commit 078bc1a471
Notes: github-actions[bot] 2025-10-13 09:01:05 +00:00
24 changed files with 172 additions and 36 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Libraries/LibWeb/CSS/CSSMathValue.h
View file

@ -8,6 +8,7 @@
#include <LibWeb/Bindings/CSSMathValuePrototype.h>
#include <LibWeb/CSS/CSSNumericValue.h>
#include <LibWeb/Forward.h>
namespace Web::CSS {
@ -31,6 +32,8 @@ public:
};
virtual String serialize_math_value(Nested, Parens) const = 0;
virtual WebIDL::ExceptionOr<NonnullRefPtr<StyleValue const>> create_an_internal_representation(PropertyNameAndID const&) const final override;
protected:
explicit CSSMathValue(JS::Realm&, Bindings::CSSMathOperator, NumericType);