mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-05 23:59:49 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb+WebContent+WebWorker: Move backing store allocation in Navigable

Browse source 
Making navigables responsible for backing store allocation will allow us
to have separate backing stores for iframes and run paint updates for
them independently, which is a step toward isolating them into separate
processes.

Another nice side effect is that now Skia backend context is ready by
the time backing stores are allocated, so we will be able to get rid of
BackingStore class in the upcoming changes and allocate PaintingSurface
directly.
This commit is contained in:
Aliaksandr Kalenik 2025-06-26 22:33:58 +02:00 • committed by Jelle Raaijmakers
commit 082053d781
Notes: github-actions[bot] 2025-07-04 14:14:12 +00:00
23 changed files with 265 additions and 262 deletions
Download patch file Download diff file Expand all files Collapse all files

40
Libraries/LibWeb/HTML/Navigable.h
View file

@ -1,6 +1,6 @@
/*
* Copyright (c) 2022, Andreas Kling <andreas@ladybird.org>
* Copyright (c) 2023, Aliaksandr Kalenik <kalenik.aliaksandr@gmail.com>
* Copyright (c) 2023-2025, Aliaksandr Kalenik <kalenik.aliaksandr@gmail.com>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -17,12 +17,14 @@
#include <LibWeb/HTML/HistoryHandlingBehavior.h>
#include <LibWeb/HTML/NavigationParams.h>
#include <LibWeb/HTML/POSTResource.h>
#include <LibWeb/HTML/RenderingThread.h>
#include <LibWeb/HTML/SandboxingFlagSet.h>
#include <LibWeb/HTML/SourceSnapshotParams.h>
#include <LibWeb/HTML/StructuredSerialize.h>
#include <LibWeb/HTML/TokenizedFeatures.h>
#include <LibWeb/InvalidateDisplayList.h>
#include <LibWeb/Page/EventHandler.h>
#include <LibWeb/Painting/BackingStoreManager.h>
#include <LibWeb/PixelUnits.h>
#include <LibWeb/XHR/FormDataEntry.h>
@ -38,6 +40,14 @@ struct TargetSnapshotParams {
SandboxingFlagSet sandboxing_flags {};
};
struct PaintConfig {
bool paint_overlay { false };
bool should_show_line_box_borders { false };
Optional<Gfx::IntRect> canvas_fill_rect {};
bool operator==(PaintConfig const& other) const = default;
};
// https://html.spec.whatwg.org/multipage/document-sequences.html#navigable
class Navigable : public JS::Cell
, public Weakable<Navigable> {
@ -170,7 +180,7 @@ public:
CSSPixelPoint viewport_scroll_offset() const { return m_viewport_scroll_offset; }
CSSPixelRect viewport_rect() const { return { m_viewport_scroll_offset, m_viewport_size }; }
CSSPixelSize viewport_size() const { return m_viewport_size; }
virtual void set_viewport_size(CSSPixelSize);
void set_viewport_size(CSSPixelSize);
void perform_scroll_of_viewport(CSSPixelPoint position);
// https://html.spec.whatwg.org/multipage/webappapis.html#rendering-opportunity
@ -195,11 +205,26 @@ public:
bool has_pending_navigations() const { return !m_pending_navigations.is_empty(); }
bool is_ready_to_paint() const;
void ready_to_paint();
void paint_next_frame();
void start_display_list_rendering(Painting::BackingStore&, PaintConfig, Function<void()>&& callback);
bool needs_repaint() const { return m_needs_repaint; }
void set_needs_repaint() { m_needs_repaint = true; }
RefPtr<Gfx::SkiaBackendContext> skia_backend_context() const { return m_skia_backend_context; }
void set_pending_set_browser_zoom_request(bool value) { m_pending_set_browser_zoom_request = value; }
bool pending_set_browser_zoom_request() const { return m_pending_set_browser_zoom_request; }
void set_should_show_line_box_borders(bool value) { m_should_show_line_box_borders = value; }
template<typename T>
bool fast_is() const = delete;
protected:
explicit Navigable(GC::Ref<Page>);
explicit Navigable(GC::Ref<Page>, bool is_svg_page);
virtual void visit_edges(Cell::Visitor&) override;
virtual void finalize() override;
@ -253,6 +278,15 @@ private:
bool m_has_session_history_entry_and_ready_for_navigation { false };
Vector<NavigateParams> m_pending_navigations;
bool m_is_svg_page { false };
bool m_needs_repaint { true };
bool m_pending_set_browser_zoom_request { false };
bool m_should_show_line_box_borders { false };
i32 m_number_of_queued_rasterization_tasks { 0 };
GC::Ref<Painting::BackingStoreManager> m_backing_store_manager;
RefPtr<Gfx::SkiaBackendContext> m_skia_backend_context;
RenderingThread m_rendering_thread;
};
HashTable<GC::RawRef<Navigable>>& all_navigables();