mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-06 16:19:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb/HTML: Correct show_popover() invocations

Browse source 
Corresponds to 47f854c66e
This commit is contained in:
Sam Atkins 2025-05-15 12:44:40 +01:00 • committed by Shannon Booth
commit 08419a6d8f
Notes: github-actions[bot] 2025-05-15 22:22:10 +00:00
1 changed files with 8 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Libraries/LibWeb/HTML/HTMLButtonElement.cpp
View file

@ -225,7 +225,8 @@ void HTMLButtonElement::activation_behavior(DOM::Event const& event)
// 9. If command is in the Hide Popover state: // 9. If command is in the Hide Popover state:
if (command == "hide-popover") { if (command == "hide-popover") {
// 1. If the result of running check popover validity given target, true, false, and null is true, then run the hide popover algorithm given target, true, true, and false. // 1. If the result of running check popover validity given target, true, false, and null is true,
// then run the hide popover algorithm given target, true, true, and false.
if (MUST(target->check_popover_validity(ExpectedToBeShowing::Yes, ThrowExceptions::No, nullptr, IgnoreDomState::No))) { if (MUST(target->check_popover_validity(ExpectedToBeShowing::Yes, ThrowExceptions::No, nullptr, IgnoreDomState::No))) {
MUST(target->hide_popover(FocusPreviousElement::Yes, FireEvents::Yes, ThrowExceptions::No, IgnoreDomState::No)); MUST(target->hide_popover(FocusPreviousElement::Yes, FireEvents::Yes, ThrowExceptions::No, IgnoreDomState::No));
} }
@ -233,12 +234,14 @@ void HTMLButtonElement::activation_behavior(DOM::Event const& event)
// 10. Otherwise, if command is in the Toggle Popover state: // 10. Otherwise, if command is in the Toggle Popover state:
else if (command == "toggle-popover") { else if (command == "toggle-popover") {
// 1. If the result of running check popover validity given target, false, false, and null is true, then run the show popover algorithm given target, true, true, and false. // 1. If the result of running check popover validity given target, false, false, and null is true,
// then run the show popover algorithm given target, false, and this.
if (MUST(target->check_popover_validity(ExpectedToBeShowing::No, ThrowExceptions::No, nullptr, IgnoreDomState::No))) { if (MUST(target->check_popover_validity(ExpectedToBeShowing::No, ThrowExceptions::No, nullptr, IgnoreDomState::No))) {
MUST(target->show_popover(ThrowExceptions::No, this)); MUST(target->show_popover(ThrowExceptions::No, this));
} }
// 2. Otheriwse, if the result of running check popover validity given target, true, false, and null is true, then run the hide popover algorithm given target, true, true, and false. // 2. Otheriwse, if the result of running check popover validity given target, true, false, and null is true,
// then run the hide popover algorithm given target, true, true, and false.
else if (MUST(target->check_popover_validity(ExpectedToBeShowing::Yes, ThrowExceptions::No, nullptr, IgnoreDomState::No))) { else if (MUST(target->check_popover_validity(ExpectedToBeShowing::Yes, ThrowExceptions::No, nullptr, IgnoreDomState::No))) {
MUST(target->hide_popover(FocusPreviousElement::Yes, FireEvents::Yes, ThrowExceptions::No, IgnoreDomState::No)); MUST(target->hide_popover(FocusPreviousElement::Yes, FireEvents::Yes, ThrowExceptions::No, IgnoreDomState::No));
} }
@ -246,7 +249,8 @@ void HTMLButtonElement::activation_behavior(DOM::Event const& event)
// 11. Otherwise, if command is in the Show Popover state: // 11. Otherwise, if command is in the Show Popover state:
else if (command == "show-popover") { else if (command == "show-popover") {
// 1. If the result of running check popover validity given target, false, false, and null is true, then run the show popover algorithm given target, true, true, and false. // 1. If the result of running check popover validity given target, false, false, and null is true,
// then run the show popover algorithm given target, false, and this.
if (MUST(target->check_popover_validity(ExpectedToBeShowing::No, ThrowExceptions::No, nullptr, IgnoreDomState::No))) { if (MUST(target->check_popover_validity(ExpectedToBeShowing::No, ThrowExceptions::No, nullptr, IgnoreDomState::No))) {
MUST(target->show_popover(ThrowExceptions::No, this)); MUST(target->show_popover(ThrowExceptions::No, this));
} }