mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-05 23:59:49 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Don't prepare script when src attribute is removed

Browse source
This commit is contained in:
Tim Ledbetter 2025-02-21 13:23:34 +00:00 • committed by Jelle Raaijmakers
commit 08b5cae199
Notes: github-actions[bot] 2025-02-22 10:40:37 +00:00
3 changed files with 46 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Libraries/LibWeb/HTML/HTMLScriptElement.cpp
View file

@ -64,6 +64,11 @@ void HTMLScriptElement::attribute_changed(FlyString const& name, Optional<String
if (namespace_.has_value()) if (namespace_.has_value())
return; return;
// AD-HOC: This ensures that prepare_script() is not called when the src attribute is removed.
// See: https://github.com/whatwg/html/pull/10188/files#r1685905457 for more information.
if (!value.has_value())
return;
// 2. If localName is src, then run the script HTML element post-connection steps, given element. // 2. If localName is src, then run the script HTML element post-connection steps, given element.
post_connection(); post_connection();
} else if (name == HTML::AttributeNames::async) { } else if (name == HTML::AttributeNames::async) {

6
Tests/LibWeb/Text/expected/wpt-import/html/semantics/scripting-1/the-script-element/remove-src-attr-prepare-a-script.txt Normal file
View file

@ -0,0 +1,6 @@
Harness status: OK
Found 1 tests
1 Pass
Pass Removing the `src` content attribute does not 'prepare' the script

35
Tests/LibWeb/Text/input/wpt-import/html/semantics/scripting-1/the-script-element/remove-src-attr-prepare-a-script.html Normal file
View file

@ -0,0 +1,35 @@
<!doctype html>
<meta charset=utf-8>
<link rel=help href=https://github.com/whatwg/html/pull/10188/files#r1685905457>
<title>Remove src attribute does not "prepare the script"</title>
<script src="../../../../resources/testharness.js"></script>
<script src="../../../../resources/testharnessreport.js"></script>
<body>
<script>
test(() => {
// Flags that the script element in this test will change, if it incorrectly
// executes.
window.didExecute = false;
window.innerTextExecuted = false;
const script = document.createElement('script');
// Invalid type, so the script won't execute upon insertion.
script.type = 'invalid';
script.src = 'resources/flag-setter.js';
script.innerText = 'window.innerTextExecuted = true';
document.body.append(script);
assert_false(window.didExecute);
assert_false(window.innerTextExecuted);
// Make script valid, but don't immediately execute it.
script.type = '';
// Removing the `src` content attribute does not trigger the "prepare a
// script" algorithm on the script.
script.removeAttribute('src');
assert_false(window.didExecute);
assert_false(window.innerTextExecuted);
}, "Removing the `src` content attribute does not 'prepare' the script");
</script>
</body>