mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-31 05:09:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Make HTML::Task IDs a sequential, distinct numeric type

Browse source 
This also fixes a bug where task IDs were being deallocated from the
wrong IDAllocator. I don't know if it was actually possible to cause any
real trouble with that mistake, nor do I know how to write a test for
it, but this makes the bug go away.
This commit is contained in:
Andreas Kling 2024-08-04 17:10:49 +02:00 • committed by Andreas Kling
commit 08d60d7521
Notes: github-actions[bot] 2024-08-05 07:12:59 +00:00
12 changed files with 33 additions and 29 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/HTML/ToggleTaskTracker.h
View file

@ -16,7 +16,7 @@ namespace Web::HTML {
struct ToggleTaskTracker {
// https://html.spec.whatwg.org/multipage/interaction.html#toggle-task-task
// NOTE: We store the task's ID rather than the task itself to avoid ownership issues.
Optional<int> task_id;
Optional<HTML::TaskID> task_id;
// https://html.spec.whatwg.org/multipage/interaction.html#toggle-task-old-state
String old_state;