LibWeb: Do not allow focusing "Actually Disabled" elements

Author: https://github.com/Simek
Commit: 09420406b8
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/2128

Userland/Libraries/LibWeb/HTML/HTMLButtonElement.cpp

@@ -107,4 +107,9 @@ void HTMLButtonElement::activation_behavior(DOM::Event const& event)
     // 4. FIXME: Run the popover target attribute activation behavior given element.
 }
 
+bool HTMLButtonElement::is_focusable() const
+{
+    return enabled();
+}
+
 }

Userland/Libraries/LibWeb/HTML/HTMLButtonElement.h

@@ -40,7 +40,9 @@ public:
 
     // ^EventTarget
     // https://html.spec.whatwg.org/multipage/interaction.html#the-tabindex-attribute:the-button-element
-    virtual bool is_focusable() const override { return true; }
+    // https://html.spec.whatwg.org/multipage/interaction.html#focusable-area
+    // https://html.spec.whatwg.org/multipage/semantics-other.html#concept-element-disabled
+    virtual bool is_focusable() const override;
 
     // ^FormAssociatedElement
     // https://html.spec.whatwg.org/multipage/forms.html#category-listed

Userland/Libraries/LibWeb/HTML/HTMLInputElement.cpp

@@ -2590,4 +2590,9 @@ HTMLInputElement::ValueAttributeMode HTMLInputElement::value_attribute_mode() co
     return value_attribute_mode_for_type_state(type_state());
 }
 
+bool HTMLInputElement::is_focusable() const
+{
+    return m_type != TypeAttributeState::Hidden && enabled();
+}
+
 }

Userland/Libraries/LibWeb/HTML/HTMLInputElement.h

@@ -155,7 +155,9 @@ public:
 
     // ^EventTarget
     // https://html.spec.whatwg.org/multipage/interaction.html#the-tabindex-attribute:the-input-element
-    virtual bool is_focusable() const override { return m_type != TypeAttributeState::Hidden; }
+    // https://html.spec.whatwg.org/multipage/interaction.html#focusable-area
+    // https://html.spec.whatwg.org/multipage/semantics-other.html#concept-element-disabled
+    virtual bool is_focusable() const override;
 
     // ^FormAssociatedElement
     // https://html.spec.whatwg.org/multipage/forms.html#category-listed

Userland/Libraries/LibWeb/HTML/HTMLSelectElement.cpp

@@ -613,4 +613,10 @@ void HTMLSelectElement::update_selectedness(JS::GCPtr<HTML::HTMLOptionElement> l
     }
     update_inner_text_element();
 }
+
+bool HTMLSelectElement::is_focusable() const
+{
+    return enabled();
+}
+
 }

Userland/Libraries/LibWeb/HTML/HTMLSelectElement.h

@@ -59,7 +59,9 @@ public:
 
     // ^EventTarget
     // https://html.spec.whatwg.org/multipage/interaction.html#the-tabindex-attribute:the-select-element
-    virtual bool is_focusable() const override { return true; }
+    // https://html.spec.whatwg.org/multipage/interaction.html#focusable-area
+    // https://html.spec.whatwg.org/multipage/semantics-other.html#concept-element-disabled
+    virtual bool is_focusable() const override;
 
     // ^FormAssociatedElement
     // https://html.spec.whatwg.org/multipage/forms.html#category-listed

Userland/Libraries/LibWeb/HTML/HTMLTextAreaElement.cpp

@@ -478,4 +478,9 @@ void HTMLTextAreaElement::queue_firing_input_event()
     });
 }
 
+bool HTMLTextAreaElement::is_focusable() const
+{
+    return enabled();
+}
+
 }

Userland/Libraries/LibWeb/HTML/HTMLTextAreaElement.h

@@ -42,7 +42,10 @@ public:
 
     // ^EventTarget
     // https://html.spec.whatwg.org/multipage/interaction.html#the-tabindex-attribute:the-textarea-element
-    virtual bool is_focusable() const override { return true; }
+    // https://html.spec.whatwg.org/multipage/interaction.html#focusable-area
+    // https://html.spec.whatwg.org/multipage/semantics-other.html#concept-element-disabled
+    virtual bool is_focusable() const override;
+
     virtual void did_lose_focus() override;
     virtual void did_receive_focus() override;