mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-10 01:59:31 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Do not clear the selection, when query is not found

Browse source 
Fixes #4743
This commit is contained in:
Chris Mulder 2025-05-15 22:08:03 +02:00 • committed by Jelle Raaijmakers
commit 09463f147d
Notes: github-actions[bot] 2025-05-26 09:24:03 +00:00
3 changed files with 8 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibWeb/Page/Page.cpp
View file

@ -726,11 +726,11 @@ Page::FindInPageResult Page::find_in_page_previous_match()
void Page::update_find_in_page_selection(Vector<GC::Root<DOM::Range>> matches) void Page::update_find_in_page_selection(Vector<GC::Root<DOM::Range>> matches)
{ {
clear_selection();
if (matches.is_empty()) if (matches.is_empty())
return; return;
clear_selection();
auto current_range = matches[m_find_in_page_match_index]; auto current_range = matches[m_find_in_page_match_index];
auto common_ancestor_container = current_range->common_ancestor_container(); auto common_ancestor_container = current_range->common_ancestor_container();
auto& document = common_ancestor_container->document(); auto& document = common_ancestor_container->document();

1
Tests/LibWeb/Text/expected/HTML/Window-find-mutations.txt
View file

@ -1,3 +1,4 @@
Selection: [object Text] 0 - [object Text] 6 Selection: [object Text] 0 - [object Text] 6
Selection: [object Text] 0 - [object Text] 3 Selection: [object Text] 0 - [object Text] 3
Selection: [object Text] 0 - [object Text] 3
Expected exception: IndexSizeError: Selection.getRangeAt() on empty Selection or with invalid argument Expected exception: IndexSizeError: Selection.getRangeAt() on empty Selection or with invalid argument

5
Tests/LibWeb/Text/input/HTML/Window-find-mutations.html
View file

@ -16,6 +16,11 @@ test(() => {
document.querySelector('div').childNodes[0].deleteData(3, 3); document.querySelector('div').childNodes[0].deleteData(3, 3);
showSelection(); showSelection();
// Try to find 'baz'.
window.find('baz');
// Selection should be untouched, since 'baz' was not found
showSelection();
// Try to find 'bar'. // Try to find 'bar'.
getSelection().empty(); getSelection().empty();
window.find('bar'); window.find('bar');