LibWeb: Avoid O(n^2) traversal in play-or-cancel-animations logic

The play_or_cancel_animations_after_display_property_change() helper was being called by Node::inserted() and Node::removed_from() and then recursing into the shadow-including subtree. This had quadratic complexity since inserted() and removed_from() are themselves already invoked recursively for everything in the shadow-including subtree. Only one caller of this API actually needed the recursive behavior, so this patch moves that responsibility to the caller and puts the logic in style recomputation instead. 1.02x speedup on Speedometer's TodoMVC-jQuery.
Author: https://github.com/awesomekling Commit: 096eed35cc Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/4693
2025-08-30 06:06:48 +00:00 · 2025-05-11 12:55:51 +02:00 · 2025-05-11 12:55:51 +02:00 · 096eed35cc · 2025-05-11 18:23:14 +00:00
commit 096eed35cc
parent 1a9e78a774
4 changed files with 44 additions and 44 deletions
--- a/Libraries/LibWeb/DOM/Node.h
+++ b/Libraries/LibWeb/DOM/Node.h
@ -562,7 +562,6 @@ public:
    bool is_inert() const;

    bool has_inclusive_ancestor_with_display_none();
-    void play_or_cancel_animations_after_display_property_change();

 protected:
    Node(JS::Realm&, Document&, NodeType);