mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-09-21 16:58:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Keep view transition pseudo styles in sync with new element

Browse source 
This makes it so that view-transition pseudo-element styles are
updated before returning them from window.getComputedStyle(). This
is necessary because they could be outdated, in case JS has
modified the styles of the elements they are trying to stay in sync
with since last frame.

The corresponding WPT test has not been imported, since it still
fails for unrelated reasons.
This commit is contained in:
Psychpsyo 2025-09-08 14:03:24 +02:00 • committed by Sam Atkins
commit 0989c3cdaf
Notes: github-actions[bot] 2025-09-10 15:40:43 +00:00
2 changed files with 7 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Libraries/LibWeb/HTML/Window.cpp
View file

@ -1308,6 +1308,13 @@ GC::Ref<CSS::CSSStyleProperties> Window::get_computed_style(DOM::Element& elemen
// TODO: Keep the function arguments of the pseudo-element if there are any.
object = { element, type.value().type() };
}
// https://drafts.csswg.org/css-view-transitions-1/#update-pseudo-element-styles
// This algorithm must be executed to update styles in user-agent origin if its effects can be observed by a web API.
// NB: View transition pseudo-elements only ever originate from the document element and only ::view-transition-group() and its descendants can be affected by update_pseudo_element_styles().
if (element.is_document_element() && first_is_one_of(type.value().type(), CSS::PseudoElement::ViewTransitionGroup, CSS::PseudoElement::ViewTransitionImagePair, CSS::PseudoElement::ViewTransitionOld, CSS::PseudoElement::ViewTransitionNew)) {
(void)element.document().active_view_transition()->update_pseudo_element_styles();
}
}
// FIXME: Implement steps 4 and 5 when we can.

4
Libraries/LibWeb/ViewTransition/ViewTransition.cpp
View file

@ -991,10 +991,6 @@ ErrorOr<void> ViewTransition::update_pseudo_element_styles()
new_->m_content = captured_element->new_element->capture_the_image();
}
}
// This algorithm must be executed to update styles in user-agent origin if its effects can be observed by a web API.
// FIXME: Find all the places where this is relevant.
return {};
}