Everywhere: Use _{short_,}string to create Strings from literals

Author: https://github.com/linusg
Commit: 09d40bfbb2
Pull-request: https://github.com/SerenityOS/serenity/pull/17619
Reviewed-by: https://github.com/AtkinsSJ
Reviewed-by: https://github.com/MacDue
Reviewed-by: https://github.com/alimpfard
Reviewed-by: https://github.com/awesomekling
Reviewed-by: https://github.com/trflynn89

Userland/Libraries/LibDSP/Effects.cpp

@@ -12,9 +12,9 @@ namespace DSP::Effects {
 
 Delay::Delay(NonnullRefPtr<Transport> transport)
     : EffectProcessor(move(transport))
-    , m_delay_decay(String::from_utf8_short_string("Decay"sv), 0.01, 0.99, 0.33, Logarithmic::No)
-    , m_delay_time(String::from_utf8("Delay Time"sv), 3, 2000, 900, Logarithmic::Yes)
-    , m_dry_gain(String::from_utf8_short_string("Dry"sv), 0, 1, 0.9, Logarithmic::No)
+    , m_delay_decay("Decay"_short_string, 0.01, 0.99, 0.33, Logarithmic::No)
+    , m_delay_time("Delay Time"_string, 3, 2000, 900, Logarithmic::Yes)
+    , m_dry_gain("Dry"_short_string, 0, 1, 0.9, Logarithmic::No)
 {
 
     m_parameters.append(m_delay_decay);
@@ -59,9 +59,9 @@ void Delay::process_impl(Signal const& input_signal, Signal& output_signal)
 
 Mastering::Mastering(NonnullRefPtr<Transport> transport)
     : EffectProcessor(move(transport))
-    , m_pan(String::from_utf8_short_string("Pan"sv), -1, 1, 0, Logarithmic::No)
-    , m_volume(String::from_utf8_short_string("Volume"sv), 0, 1, 1, Logarithmic::No)
-    , m_muted(String::from_utf8_short_string("Mute"sv), false)
+    , m_pan("Pan"_short_string, -1, 1, 0, Logarithmic::No)
+    , m_volume("Volume"_short_string, 0, 1, 1, Logarithmic::No)
+    , m_muted("Mute"_short_string, false)
 {
     m_parameters.append(m_muted);
     m_parameters.append(m_volume);