Everywhere: Use _{short_,}string to create Strings from literals

Author: https://github.com/linusg
Commit: 09d40bfbb2
Pull-request: https://github.com/SerenityOS/serenity/pull/17619
Reviewed-by: https://github.com/AtkinsSJ
Reviewed-by: https://github.com/MacDue
Reviewed-by: https://github.com/alimpfard
Reviewed-by: https://github.com/awesomekling
Reviewed-by: https://github.com/trflynn89

Userland/Libraries/LibGUI/IncrementalSearchBanner.cpp

@@ -37,7 +37,7 @@ IncrementalSearchBanner::IncrementalSearchBanner(TextEditor& editor)
     };
 
     m_close_button = find_descendant_of_type_named<Button>("incremental_search_banner_close_button");
-    m_close_button->set_text(String::from_utf8_short_string("\xE2\x9D\x8C"sv));
+    m_close_button->set_text("\xE2\x9D\x8C"_short_string);
     m_close_button->on_click = [this](auto) {
         hide();
     };