mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-12 12:01:52 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

AK+Everywhere: Change StringView case conversions to return String

Browse source 
There's a bit of a UTF-8 assumption with this change. But nearly every
caller of these methods were immediately creating a String from the
resulting ByteString anyways.
This commit is contained in:
Timothy Flynn 2025-04-06 10:19:35 -04:00 • committed by Andreas Kling
parent 05627b6f45
commit 0a256b0a9a
Notes: github-actions[bot] 2025-04-07 15:45:50 +00:00
15 changed files with 57 additions and 56 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibWeb/Encoding/TextDecoder.cpp
View file

@ -32,7 +32,7 @@ WebIDL::ExceptionOr<GC::Ref<TextDecoder>> TextDecoder::construct_impl(JS::Realm&
// 3. Set this’s encoding to encoding.
// https://encoding.spec.whatwg.org/#dom-textdecoder-encoding
// The encoding getter steps are to return this’s encoding’s name, ASCII lowercased.
auto lowercase_encoding_name = MUST(String::from_byte_string(encoding.value().to_lowercase_string()));
auto lowercase_encoding_name = encoding.value().to_ascii_lowercase_string();
// 4. If options["fatal"] is true, then set this’s error mode to "fatal".
auto fatal = options.value_or({}).fatal;