mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-04 08:01:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

AK+Everywhere: Change StringView case conversions to return String

Browse source 
There's a bit of a UTF-8 assumption with this change. But nearly every
caller of these methods were immediately creating a String from the
resulting ByteString anyways.
This commit is contained in:
Timothy Flynn 2025-04-06 10:19:35 -04:00 • committed by Andreas Kling
parent 05627b6f45
commit 0a256b0a9a
Notes: github-actions[bot] 2025-04-07 15:45:50 +00:00
15 changed files with 57 additions and 56 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibWeb/HTML/TokenizedFeatures.cpp
View file

@ -68,7 +68,7 @@ TokenizedFeature::Map tokenize_open_features(StringView features)
lexer.ignore_while(is_feature_separator);
// 4. Collect a sequence of code points that are not feature separators from features given position. Set name to the collected characters, converted to ASCII lowercase.
name = MUST(String::from_byte_string(lexer.consume_until(is_feature_separator).to_lowercase_string()));
name = lexer.consume_until(is_feature_separator).to_ascii_lowercase_string();
// 5. Set name to the result of normalizing the feature name name.
name = normalize_feature_name(name);
@ -85,7 +85,7 @@ TokenizedFeature::Map tokenize_open_features(StringView features)
lexer.ignore_while([](auto character) { return Infra::is_ascii_whitespace(character) || character == '='; });
// 2. Collect a sequence of code points that are not feature separators code points from features given position. Set value to the collected code points, converted to ASCII lowercase.
value = MUST(String::from_byte_string(lexer.consume_until(is_feature_separator).to_lowercase_string()));
value = lexer.consume_until(is_feature_separator).to_ascii_lowercase_string();
// 8. If name is not the empty string, then set tokenizedFeatures[name] to value.
if (!name.is_empty())