From 0a578ee3452217701c61ba8ac8e66b0d71e714a0 Mon Sep 17 00:00:00 2001 From: Sam Atkins Date: Thu, 31 Oct 2024 11:51:18 +0000 Subject: [PATCH] LibWeb/HTML: Update spec comments for "URL and history update steps" Corresponds to: https://github.com/whatwg/html/pull/10587 --- Userland/Libraries/LibWeb/HTML/Navigable.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Userland/Libraries/LibWeb/HTML/Navigable.cpp b/Userland/Libraries/LibWeb/HTML/Navigable.cpp index deafbed0d77..32d6571ccbe 100644 --- a/Userland/Libraries/LibWeb/HTML/Navigable.cpp +++ b/Userland/Libraries/LibWeb/HTML/Navigable.cpp @@ -1933,7 +1933,6 @@ void perform_url_and_history_update_steps(DOM::Document& document, URL::URL new_ // 2. Let activeEntry be navigable's active session history entry. auto active_entry = navigable->active_session_history_entry(); - // FIXME: Spec should be updated to say "classic history api state" instead of serialized state // 3. Let newEntry be a new session history entry, with // URL: newURL // serialized state: if serializedData is not null, serializedData; otherwise activeEntry's classic history API state @@ -1988,6 +1987,8 @@ void perform_url_and_history_update_steps(DOM::Document& document, URL::URL new_ traversable->append_session_history_synchronous_navigation_steps(*navigable, JS::create_heap_function(document.realm().heap(), [traversable, navigable, new_entry, entry_to_replace, history_handling] { // 1. Finalize a same-document navigation given traversable, navigable, newEntry, and entryToReplace. finalize_a_same_document_navigation(*traversable, *navigable, new_entry, entry_to_replace, history_handling); + + // 2. FIXME: Invoke WebDriver BiDi history updated with navigable. })); }