mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-08-07 08:39:22 +00:00
LibWeb: Check if types have a present and nonzero percentage value
Co-authored-by: Chase Knowlden <haroldknowlden@gmail.com> Co-authored-by: "tanner.drake" <tanner.drake@protonmail.com>
This commit is contained in:
parent
436417aabe
commit
0a6793c89b
Notes:
github-actions[bot]
2024-12-30 10:10:08 +00:00
Author: https://github.com/Gingeh
Commit: 0a6793c89b
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/3083
3 changed files with 35 additions and 1 deletions
|
@ -154,7 +154,7 @@ Optional<CSSNumericType> CSSNumericType::added_to(CSSNumericType const& other) c
|
||||||
}
|
}
|
||||||
// If type1 and/or type2 contain "percent" with a non-zero value,
|
// If type1 and/or type2 contain "percent" with a non-zero value,
|
||||||
// and type1 and/or type2 contain a key other than "percent" with a non-zero value
|
// and type1 and/or type2 contain a key other than "percent" with a non-zero value
|
||||||
if ((type1.exponent(BaseType::Percent) != 0 || type2.exponent(BaseType::Percent) != 0)
|
if (((type1.exponent(BaseType::Percent).has_value() && type1.exponent(BaseType::Percent) != 0) || (type2.exponent(BaseType::Percent).has_value() && type2.exponent(BaseType::Percent) != 0))
|
||||||
&& (type1.contains_a_key_other_than_percent_with_a_non_zero_value() || type2.contains_a_key_other_than_percent_with_a_non_zero_value())) {
|
&& (type1.contains_a_key_other_than_percent_with_a_non_zero_value() || type2.contains_a_key_other_than_percent_with_a_non_zero_value())) {
|
||||||
// For each base type other than "percent" hint:
|
// For each base type other than "percent" hint:
|
||||||
for (auto hint_int = 0; hint_int < to_underlying(BaseType::__Count); ++hint_int) {
|
for (auto hint_int = 0; hint_int < to_underlying(BaseType::__Count); ++hint_int) {
|
||||||
|
|
|
@ -0,0 +1 @@
|
||||||
|
<html style="background: green"></html>
|
|
@ -0,0 +1,33 @@
|
||||||
|
<!DOCTYPE html>
|
||||||
|
<html>
|
||||||
|
<head>
|
||||||
|
<meta charset="utf-8">
|
||||||
|
<title>CSS Values and Units Test: min() with unitless 0</title>
|
||||||
|
|
||||||
|
<meta name="assert" content="Unitless 0 isn't supported in math functions.">
|
||||||
|
<link rel="author" title="Fuqiao Xue" href="mailto:xfq@w3.org">
|
||||||
|
<link rel="help" href="https://drafts.csswg.org/css-values/#calc-type-checking">
|
||||||
|
<link rel="match" href="../../../../expected/wpt-import/css/css-values/reference/all-green.html">
|
||||||
|
|
||||||
|
<style>
|
||||||
|
html, body { margin: 0px; padding: 0px; }
|
||||||
|
|
||||||
|
html { background: red; overflow: hidden; }
|
||||||
|
#outer { position: absolute; top: 0px; left: 0px; background: green; width: 100%; }
|
||||||
|
|
||||||
|
#outer {
|
||||||
|
/* Assert that min() is supported */
|
||||||
|
height: min(100%);
|
||||||
|
|
||||||
|
/* The min() expression (thus the declaration) should be invalid */
|
||||||
|
height: min(0, 100%);
|
||||||
|
}
|
||||||
|
</style>
|
||||||
|
|
||||||
|
</head>
|
||||||
|
<body>
|
||||||
|
|
||||||
|
<div id="outer"></div>
|
||||||
|
|
||||||
|
</body>
|
||||||
|
</html>
|
Loading…
Add table
Add a link
Reference in a new issue