mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-09 17:49:40 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibJS: Adjust FIXME for an incorrect assertion in GetModuleNamespace

Browse source 
It turns out that the FIXME which we had left unimplemented is actually
a spec bug.
This commit is contained in:
Shannon Booth 2025-01-01 16:20:56 +13:00 • committed by Andreas Kling
commit 0b2c80e503
Notes: github-actions[bot] 2025-01-02 10:31:50 +00:00
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibJS/Module.cpp
View file

@ -123,7 +123,7 @@ void finish_loading_imported_module(ImportedModuleReferrer referrer, ModuleReque
ThrowCompletionOr<Object*> Module::get_module_namespace(VM& vm) ThrowCompletionOr<Object*> Module::get_module_namespace(VM& vm)
{ {
// 1. Assert: If module is a Cyclic Module Record, then module.[[Status]] is not unlinked. // 1. Assert: If module is a Cyclic Module Record, then module.[[Status]] is not unlinked.
// FIXME: How do we check this without breaking encapsulation? // FIXME: Spec bug: https://github.com/tc39/ecma262/issues/3114
// 2. Let namespace be module.[[Namespace]]. // 2. Let namespace be module.[[Namespace]].
auto* namespace_ = m_namespace.ptr(); auto* namespace_ = m_namespace.ptr();