mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-29 12:19:54 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Remove some useless URL validity checks

Browse source 
It is not possible for a URL here to have a value and be invalid.
This commit is contained in:
Shannon Booth 2025-02-16 14:06:50 +13:00 • committed by Tim Flynn
commit 0b8bcdcbd3
Notes: github-actions[bot] 2025-02-19 13:03:07 +00:00
3 changed files with 0 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibWeb/HTML/Navigable.cpp
View file

@ -1015,8 +1015,6 @@ static WebIDL::ExceptionOr<Navigable::NavigationParamsVariant> create_navigation
} }
// 16. Assert: locationURL is a URL. // 16. Assert: locationURL is a URL.
VERIFY(location_url.value()->is_valid());
// 17. Set entry's classic history API state to StructuredSerializeForStorage(null). // 17. Set entry's classic history API state to StructuredSerializeForStorage(null).
entry->set_classic_history_api_state(MUST(structured_serialize_for_storage(vm, JS::js_null()))); entry->set_classic_history_api_state(MUST(structured_serialize_for_storage(vm, JS::js_null())));

4
Libraries/LibWeb/HTML/Scripting/Fetching.cpp
View file

@ -186,8 +186,6 @@ WebIDL::ExceptionOr<Optional<URL::URL>> resolve_imports_match(ByteString const&
return WebIDL::SimpleException { WebIDL::SimpleExceptionType::TypeError, String::formatted("Import resolution of '{}' was blocked by a null entry.", specifier_key).release_value_but_fixme_should_propagate_errors() }; return WebIDL::SimpleException { WebIDL::SimpleExceptionType::TypeError, String::formatted("Import resolution of '{}' was blocked by a null entry.", specifier_key).release_value_but_fixme_should_propagate_errors() };
// 2. Assert: resolutionResult is a URL. // 2. Assert: resolutionResult is a URL.
VERIFY(resolution_result->is_valid());
// 3. Return resolutionResult. // 3. Return resolutionResult.
return resolution_result; return resolution_result;
} }
@ -207,8 +205,6 @@ WebIDL::ExceptionOr<Optional<URL::URL>> resolve_imports_match(ByteString const&
return WebIDL::SimpleException { WebIDL::SimpleExceptionType::TypeError, String::formatted("Import resolution of '{}' was blocked by a null entry.", specifier_key).release_value_but_fixme_should_propagate_errors() }; return WebIDL::SimpleException { WebIDL::SimpleExceptionType::TypeError, String::formatted("Import resolution of '{}' was blocked by a null entry.", specifier_key).release_value_but_fixme_should_propagate_errors() };
// 2. Assert: resolutionResult is a URL. // 2. Assert: resolutionResult is a URL.
VERIFY(resolution_result->is_valid());
// 3. Let afterPrefix be the portion of normalizedSpecifier after the initial specifierKey prefix. // 3. Let afterPrefix be the portion of normalizedSpecifier after the initial specifierKey prefix.
// FIXME: Clarify if this is meant by the portion after the initial specifierKey prefix. // FIXME: Clarify if this is meant by the portion after the initial specifierKey prefix.
auto after_prefix = normalized_specifier.substring(specifier_key.length()); auto after_prefix = normalized_specifier.substring(specifier_key.length());

3
Libraries/LibWeb/SVG/SVGUseElement.cpp
View file

@ -136,9 +136,6 @@ GC::Ptr<DOM::Element> SVGUseElement::referenced_element()
if (!m_href.has_value()) if (!m_href.has_value())
return nullptr; return nullptr;
if (!m_href->is_valid())
return nullptr;
if (!m_href->fragment().has_value()) if (!m_href->fragment().has_value())
return nullptr; return nullptr;