mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-07 00:29:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb/CSS: Serialize overflow correctly

Browse source 
When the x and y values are the same, we only want to serialize one.

This gets us 10 local WPT subtest passes. :^)
This commit is contained in:
Sam Atkins 2024-11-29 13:37:25 +00:00 • committed by Andreas Kling
commit 0c39d07b4d
Notes: github-actions[bot] 2024-11-30 10:02:56 +00:00
4 changed files with 23 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Libraries/LibWeb/CSS/StyleValues/ShorthandStyleValue.cpp
View file

@ -183,8 +183,14 @@ String ShorthandStyleValue::to_string() const
} }
case PropertyID::ListStyle: case PropertyID::ListStyle:
return MUST(String::formatted("{} {} {}", longhand(PropertyID::ListStylePosition)->to_string(), longhand(PropertyID::ListStyleImage)->to_string(), longhand(PropertyID::ListStyleType)->to_string())); return MUST(String::formatted("{} {} {}", longhand(PropertyID::ListStylePosition)->to_string(), longhand(PropertyID::ListStyleImage)->to_string(), longhand(PropertyID::ListStyleType)->to_string()));
case PropertyID::Overflow: case PropertyID::Overflow: {
return MUST(String::formatted("{} {}", longhand(PropertyID::OverflowX)->to_string(), longhand(PropertyID::OverflowY)->to_string())); auto overflow_x = longhand(PropertyID::OverflowX);
auto overflow_y = longhand(PropertyID::OverflowY);
if (overflow_x == overflow_y)
return overflow_x->to_string();
return MUST(String::formatted("{} {}", overflow_x->to_string(), overflow_y->to_string()));
}
case PropertyID::PlaceContent: { case PropertyID::PlaceContent: {
auto align_content = longhand(PropertyID::AlignContent)->to_string(); auto align_content = longhand(PropertyID::AlignContent)->to_string();
auto justify_content = longhand(PropertyID::JustifyContent)->to_string(); auto justify_content = longhand(PropertyID::JustifyContent)->to_string();

2
Tests/LibWeb/Text/expected/css/CSSStyleDeclaration-all-supported-properties-and-default-values.txt
View file

@ -443,7 +443,7 @@ All supported properties and their default values exposed from CSSStyleDeclarati
'outline-style': 'none' 'outline-style': 'none'
'outlineWidth': 'medium' 'outlineWidth': 'medium'
'outline-width': 'medium' 'outline-width': 'medium'
'overflow': 'visible visible' 'overflow': 'visible'
'overflowX': 'visible' 'overflowX': 'visible'
'overflow-x': 'visible' 'overflow-x': 'visible'
'overflowY': 'visible' 'overflowY': 'visible'

14
Tests/LibWeb/Text/expected/wpt-import/css/cssom/overflow-serialization.txt
View file

@ -6,16 +6,16 @@ Rerun
Found 10 tests Found 10 tests
2 Pass 7 Pass
8 Fail 3 Fail
Details Details
Result Test Name MessagePass Single value overflow with CSS-wide keyword should serialize correctly. Result Test Name MessagePass Single value overflow with CSS-wide keyword should serialize correctly.
Fail Single value overflow with non-CSS-wide keyword should serialize correctly. Pass Single value overflow with non-CSS-wide keyword should serialize correctly.
Fail Overflow-x/y longhands with same CSS-wide keyword should serialize correctly. Fail Overflow-x/y longhands with same CSS-wide keyword should serialize correctly.
Fail Overflow-x/y longhands with same non-CSS-wide keyword should serialize correctly. Fail Overflow-x/y longhands with same non-CSS-wide keyword should serialize correctly.
Fail Overflow-x/y longhands with different keywords should serialize correctly. Fail Overflow-x/y longhands with different keywords should serialize correctly.
Fail Single value overflow on element with CSS-wide keyword should serialize correctly. Pass Single value overflow on element with CSS-wide keyword should serialize correctly.
Fail Single value overflow on element with non-CSS-wide keyword should serialize correctly. Pass Single value overflow on element with non-CSS-wide keyword should serialize correctly.
Fail Overflow-x/y longhands on element with same CSS-wide keyword should serialize correctly. Pass Overflow-x/y longhands on element with same CSS-wide keyword should serialize correctly.
Fail Overflow-x/y longhands on element with same non-CSS-wide keyword should serialize correctly. Pass Overflow-x/y longhands on element with same non-CSS-wide keyword should serialize correctly.
Pass Overflow-x/y longhands on element with different keywords should serialize correctly. Pass Overflow-x/y longhands on element with different keywords should serialize correctly.

14
Tests/LibWeb/Text/expected/wpt-import/css/cssom/serialize-values.txt
View file

@ -6,8 +6,8 @@ Rerun
Found 687 tests Found 687 tests
466 Pass 471 Pass
221 Fail 216 Fail
Details Details
Result Test Name MessagePass background-attachment: scroll Result Test Name MessagePass background-attachment: scroll
Pass background-attachment: fixed Pass background-attachment: fixed
@ -561,11 +561,11 @@ Pass outline-width: 0px
Pass outline-width: 1px Pass outline-width: 1px
Pass outline-width: .1em Pass outline-width: .1em
Pass outline-width: inherit Pass outline-width: inherit
Fail overflow: visible Pass overflow: visible
Fail overflow: hidden Pass overflow: hidden
Fail overflow: scroll Pass overflow: scroll
Fail overflow: auto Pass overflow: auto
Fail overflow: inherit Pass overflow: inherit
Pass padding-top: 0px Pass padding-top: 0px
Pass padding-top: 1px Pass padding-top: 1px
Pass padding-top: .1em Pass padding-top: .1em