From 0c799b23cbf444f46e794d10745a14d79eff5ef1 Mon Sep 17 00:00:00 2001 From: Shannon Booth Date: Sun, 12 May 2024 22:16:12 +1200 Subject: [PATCH] LibWeb: Use WebIDL::UnsignedLong for deltaMode in WheelEvent This matches the IDL definition. Without this we experience a compile time error when adding the WheelEvent constructor due to a mimatched type between the enum class and UnsignedLong that the prototype is passing through to the event init struct for the constructor. --- Userland/Libraries/LibWeb/UIEvents/WheelEvent.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Userland/Libraries/LibWeb/UIEvents/WheelEvent.h b/Userland/Libraries/LibWeb/UIEvents/WheelEvent.h index dff0d57c26e..ec8e37f282a 100644 --- a/Userland/Libraries/LibWeb/UIEvents/WheelEvent.h +++ b/Userland/Libraries/LibWeb/UIEvents/WheelEvent.h @@ -12,7 +12,7 @@ namespace Web::UIEvents { -enum class WheelDeltaMode : WebIDL::UnsignedLong { +enum WheelDeltaMode : WebIDL::UnsignedLong { DOM_DELTA_PIXEL = 0, DOM_DELTA_LINE = 1, DOM_DELTA_PAGE = 2, @@ -23,7 +23,7 @@ struct WheelEventInit : public MouseEventInit { double delta_y = 0; double delta_z = 0; - WheelDeltaMode delta_mode = WheelDeltaMode::DOM_DELTA_PIXEL; + WebIDL::UnsignedLong delta_mode = WheelDeltaMode::DOM_DELTA_PIXEL; }; class WheelEvent final : public MouseEvent { @@ -39,7 +39,7 @@ public: double delta_x() const { return m_delta_x; } double delta_y() const { return m_delta_y; } double delta_z() const { return m_delta_z; } - WebIDL::UnsignedLong delta_mode() const { return to_underlying(m_delta_mode); } + WebIDL::UnsignedLong delta_mode() const { return m_delta_mode; } private: WheelEvent(JS::Realm&, FlyString const& event_name, WheelEventInit const& event_init, double page_x, double page_y, double offset_x, double offset_y); @@ -51,7 +51,7 @@ private: double m_delta_x { 0 }; double m_delta_y { 0 }; double m_delta_z { 0 }; - WheelDeltaMode m_delta_mode { WheelDeltaMode::DOM_DELTA_PIXEL }; + WebIDL::UnsignedLong m_delta_mode { WheelDeltaMode::DOM_DELTA_PIXEL }; }; }