mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-26 12:17:52 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Don't allow "display: none" start CSS animations

Browse source 
This is both a correctness fix and a performance optimization.
This commit is contained in:
Aliaksandr Kalenik 2025-01-31 22:26:59 +01:00 • committed by Alexander Kalenik
commit 0cfe90b59e
Notes: github-actions[bot] 2025-02-01 12:42:56 +00:00
6 changed files with 116 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

35
Tests/LibWeb/Text/input/wpt-import/css/css-animations/display-none-prevents-starting-in-subtree.html Normal file
View file

@ -0,0 +1,35 @@
<!DOCTYPE html>
<link rel=author href="mailto:graouts@webkit.org">
<link rel=help href="https://drafts.csswg.org/css-animations/#animations">
<script src="../../resources/testharness.js"></script>
<script src="../../resources/testharnessreport.js"></script>
<script src="../../css/css-animations/support/testcommon.js"></script>
<style>
@keyframes margin {
100% { margin-left: 200px }
}
#child {
animation: margin 1s forwards;
}
</style>
<div id="container">
<div>
<div id="child"></div>
</div>
</div>
<script>
test(() => {
const container = document.getElementById("container");
const animationCount = () => container.getAnimations({ subtree: true }).length;
assert_equals(animationCount(), 1, `An animation is running on the child initially with "display: block" on the container.`);
container.style.display = "none";
assert_equals(animationCount(), 0, `Setting "display: none" on the container canceled the animation.`);
container.style.marginLeft = "50px";
container.firstElementChild.style.marginLeft = "100px";
assert_equals(animationCount(), 0, `Manipulating styles on the container and a child element does not restart the animation.`);
}, 'Elements in a "display: none" tree cannot start CSS Animations.');
</script>