mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-09-10 19:46:03 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibGfx: Slightly simplify Path::append_segment()

Browse source 
Rather than reorder the points here, just update the callers.

No behaviour change.
This commit is contained in:
MacDue 2024-03-19 12:28:36 +00:00 • committed by Tim Flynn
commit 0d7107e1d3
Notes: sideshowbarker 2024-07-17 09:49:33 +09:00
1 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

14
Userland/Libraries/LibGfx/Path.h
View file

@ -166,13 +166,13 @@ public:
void quadratic_bezier_curve_to(FloatPoint through, FloatPoint point) void quadratic_bezier_curve_to(FloatPoint through, FloatPoint point)
{ {
append_segment<PathSegment::QuadraticBezierCurveTo>(point, through); append_segment<PathSegment::QuadraticBezierCurveTo>(through, point);
invalidate_split_lines(); invalidate_split_lines();
} }
void cubic_bezier_curve_to(FloatPoint c1, FloatPoint c2, FloatPoint p2) void cubic_bezier_curve_to(FloatPoint c1, FloatPoint c2, FloatPoint p2)
{ {
append_segment<PathSegment::CubicBezierCurveTo>(p2, c1, c2); append_segment<PathSegment::CubicBezierCurveTo>(c1, c2, p2);
invalidate_split_lines(); invalidate_split_lines();
} }
@ -254,14 +254,14 @@ private:
void segmentize_path(); void segmentize_path();
template<PathSegment::Command command, typename... Args> template<PathSegment::Command command, typename... Args>
void append_segment(FloatPoint point, Args&&... args) void append_segment(Args&&... args)
{ {
constexpr auto point_count = sizeof...(Args) + 1; constexpr auto point_count = sizeof...(Args);
static_assert(point_count == PathSegment::points_per_command(command)); static_assert(point_count == PathSegment::points_per_command(command));
m_commands.append(command); FloatPoint points[] { args... };
// Place the current path point after any extra control points so `m_points.last()` is always the last point. // Note: This should maintain the invariant that `m_points.last()` is always the last point in the path.
FloatPoint points[] { args..., point };
m_points.append(points, point_count); m_points.append(points, point_count);
m_commands.append(command);
} }
Vector<FloatPoint> m_points {}; Vector<FloatPoint> m_points {};