mirrors/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-04-21 20:15:17 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb: Add FIXME about definiteness to UsedValues::set_content_width()

Browse source 
Fixing this function will be quite an undertaking since a *lot* of code
relies on set_content_width() implicitly flipping the definiteness of
the width. It is wrong though, so we do need to fix it eventually.
This commit is contained in:
Andreas Kling 2024-02-21 15:27:37 +01:00
parent 221650f3cd
commit 0dd8458683
Notes: sideshowbarker 2024-07-17 09:49:33 +09:00
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/Layout/LayoutState.cpp
View file

@ -495,6 +495,8 @@ void LayoutState::UsedValues::set_content_width(CSSPixels width)
width = 0;
}
m_content_width = width;
// FIXME: We should not do this! Definiteness of widths should be determined early,
// and not changed later (except for some special cases in flex layout..)
m_has_definite_width = true;
}