mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-09 01:29:17 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibIPC: Don't generate "take" methods for primitive/simple types

Browse source
This commit is contained in:
Timothy Flynn 2025-03-08 15:43:57 -05:00 • committed by Tim Flynn
commit 0e057d3a36
Notes: github-actions[bot] 2025-03-09 15:15:15 +00:00
1 changed files with 12 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Meta/Lagom/Tools/CodeGenerators/IPCCompiler/main.cpp
View file

@ -493,10 +493,16 @@ public:)~~~");
auto parameter_generator = message_generator.fork(); auto parameter_generator = message_generator.fork();
parameter_generator.set("parameter.type", parameter.type); parameter_generator.set("parameter.type", parameter.type);
parameter_generator.set("parameter.name", parameter.name); parameter_generator.set("parameter.name", parameter.name);
if (is_primitive_or_simple_type(parameter.type)) {
parameter_generator.appendln(R"~~~(
@parameter.type@ @parameter.name@() const { return m_@parameter.name@; })~~~");
} else {
parameter_generator.appendln(R"~~~( parameter_generator.appendln(R"~~~(
const @parameter.type@& @parameter.name@() const { return m_@parameter.name@; } const @parameter.type@& @parameter.name@() const { return m_@parameter.name@; }
@parameter.type@ take_@parameter.name@() { return move(m_@parameter.name@); })~~~"); @parameter.type@ take_@parameter.name@() { return move(m_@parameter.name@); })~~~");
} }
}
message_generator.append(R"~~~( message_generator.append(R"~~~(
private:)~~~"); private:)~~~");
@ -617,7 +623,11 @@ void generate_proxy_method(SourceGenerator& message_generator, Endpoint const& e
} }
if (message.outputs.size() == 1) { if (message.outputs.size() == 1) {
if (is_primitive_or_simple_type(message.outputs[0].type))
message_generator.append("->");
else
message_generator.append("->take_"); message_generator.append("->take_");
message_generator.append(message.outputs[0].name); message_generator.append(message.outputs[0].name);
message_generator.append("()"); message_generator.append("()");
} else } else