mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-05-21 18:42:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

JSSpecCompiler: Let FunctionDeclaration know its name and category

Browse source 
This is achieved by moving ClauseHeader::{AbstractOperation,Accessor,
Method} to Function.h itself and storing them in FunctionDeclaration.

This commit also introduces QualifiedName class that is used to store
function's name split by '.' (just like it appear in the spec).
This commit is contained in:
Dan Klishch 2024-03-11 15:51:14 -04:00 • committed by Andrew Kaster
parent 70cfa60f56
commit 0e7c33b1be
Notes: sideshowbarker 2024-07-17 01:46:43 +09:00
12 changed files with 170 additions and 96 deletions
Download patch file Download diff file Expand all files Collapse all files

28
Meta/Lagom/Tools/CodeGenerators/JSSpecCompiler/Parser/SpecificationFunction.cpp
View file

@ -15,35 +15,29 @@ bool SpecificationFunction::post_initialize(XML::Node const* element)
VERIFY(element->as_element().name == tag_emu_clause);
auto& ctx = context();
m_location = ctx.location_from_xml_offset(element->offset);
auto maybe_id = get_attribute_by_name(element, attribute_id);
if (!maybe_id.has_value()) {
ctx.diag().error(ctx.location_from_xml_offset(element->offset),
ctx.diag().error(m_location,
"no id attribute");
} else {
m_id = maybe_id.value();
}
m_header.header.visit(
[&](ClauseHeader::AbstractOperation const& abstract_operation) {
auto maybe_abstract_operation_id = get_attribute_by_name(element, attribute_aoid);
if (maybe_abstract_operation_id.has_value())
m_name = MUST(String::from_utf8(maybe_abstract_operation_id.value()));
[&](AbstractOperationDeclaration const& abstract_operation) {
m_declaration = abstract_operation;
auto const& [function_name, arguments] = abstract_operation;
m_arguments = arguments;
auto abstract_operation_id = get_attribute_by_name(element, attribute_aoid).value();
if (m_name != function_name) {
ctx.diag().warn(ctx.location_from_xml_offset(element->offset),
if (abstract_operation.name != abstract_operation_id) {
ctx.diag().warn(m_location,
"function name in header and <emu-clause>[aoid] do not match");
}
},
[&](ClauseHeader::Accessor const& accessor) {
m_name = MUST(String::formatted("%get {}%", MUST(String::join("."sv, accessor.qualified_name))));
},
[&](ClauseHeader::Method const& method) {
m_name = MUST(String::formatted("%{}%", MUST(String::join("."sv, method.qualified_name))));
m_arguments = method.arguments;
[&](OneOf<AccessorDeclaration, MethodDeclaration> auto const& declaration) {
m_declaration = declaration;
},
[&](auto const&) {
VERIFY_NOT_REACHED();
@ -70,7 +64,7 @@ bool SpecificationFunction::post_initialize(XML::Node const* element)
}
if (algorithm_nodes.size() != 1) {
ctx.diag().error(ctx.location_from_xml_offset(element->offset),
ctx.diag().error(m_location,
"<emu-clause> specifing function should have exactly one <emu-alg> child"sv);
return false;
}
@ -86,7 +80,7 @@ bool SpecificationFunction::post_initialize(XML::Node const* element)
void SpecificationFunction::do_collect(TranslationUnitRef translation_unit)
{
translation_unit->adopt_function(make_ref_counted<FunctionDefinition>(m_name, m_algorithm.tree(), move(m_arguments)));
translation_unit->adopt_function(make_ref_counted<FunctionDefinition>(m_declaration.release_value(), m_location, m_algorithm.tree()));
}
}