mirrors/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-04-21 12:05:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb: Check if navigable has active window before navigating

Browse source 
Fixes https://github.com/LadybirdBrowser/ladybird/issues/3733
This commit is contained in:
Aliaksandr Kalenik 2025-02-28 22:35:07 +01:00 • committed by Alexander Kalenik
parent ea3b7efd91
commit 0f697193f0
Notes: github-actions[bot] 2025-02-28 22:16:27 +00:00
3 changed files with 26 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibWeb/HTML/Navigable.cpp
View file

@ -1342,6 +1342,10 @@ WebIDL::ExceptionOr<void> Navigable::populate_session_history_entry_document(
WebIDL::ExceptionOr<void> Navigable::navigate(NavigateParams params)
{
// AD-HOC: Not in the spec but subsequent steps will fail if the navigable doesn't have an active window.
if (!active_window())
return {};
auto source_document = params.source_document;
auto exceptions_enabled = params.exceptions_enabled;
auto& active_document = *this->active_document();

1
Tests/LibWeb/Assets/blank.html Normal file
View file

@ -0,0 +1 @@
<div>blank page</div>

21
Tests/LibWeb/Crash/HTML/navigate-navigable-without-active-window.html Normal file
View file

@ -0,0 +1,21 @@
<!DOCTYPE html>
<body></body>
<script>
function test(name) {
const form = document.body.appendChild(document.createElement("form"));
const target = document.createElement("iframe");
target.name = name;
form.action = "../../Assets/blank.html";
document.body.appendChild(target);
form.target = target.name;
form.submit();
target.addEventListener("load", () => {
document.body.removeChild(form);
document.body.removeChild(target);
});
}
test("1");
test("2");
test("3");
</script>