mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-29 20:29:18 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibJS/Bytecode: Only emit ResolveThisBinding once per basic block

Browse source 
Once executed, this instruction will always produce the same result
in subsequent executions, so it's okay to cache it.

Unfortunately it may throw, so we can't just hoist it to the top of
every executable, since that would break observable execution order.
This commit is contained in:
Andreas Kling 2024-05-07 12:16:37 +02:00
commit 0f70ff9a67
Notes: sideshowbarker 2024-07-17 08:43:11 +09:00
4 changed files with 21 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Userland/Libraries/LibJS/Bytecode/Generator.cpp
View file

@ -798,4 +798,14 @@ void Generator::set_local_initialized(u32 local_index)
m_initialized_locals.set(local_index);
}
Operand Generator::get_this(Optional<Operand> preferred_dst)
{
if (m_current_basic_block->this_().has_value())
return m_current_basic_block->this_().value();
auto dst = preferred_dst.has_value() ? preferred_dst.value() : Operand(allocate_register());
emit<Bytecode::Op::ResolveThisBinding>(dst);
m_current_basic_block->set_this(dst);
return dst;
}
}