mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-10-27 18:40:00 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibDevTools: Don't assume computed layout values are strings
Some checks are pending
CI / macOS, arm64, Sanitizer, Clang (push) Waiting to run
Details
CI / Linux, x86_64, Fuzzers, Clang (push) Waiting to run
Details
CI / Linux, x86_64, Sanitizer, GNU (push) Waiting to run
Details
CI / Linux, x86_64, Sanitizer, Clang (push) Waiting to run
Details
Package the js repl as a binary artifact / Linux, arm64 (push) Waiting to run
Details
Package the js repl as a binary artifact / macOS, arm64 (push) Waiting to run
Details
Package the js repl as a binary artifact / Linux, x86_64 (push) Waiting to run
Details
Run test262 and test-wasm / run_and_update_results (push) Waiting to run
Details
Lint Code / lint (push) Waiting to run
Details
Label PRs with merge conflicts / auto-labeler (push) Waiting to run
Details
Push notes / build (push) Waiting to run
Details

Browse source 
Width and height are doubles, so get_string() will return nothing and
fail. We just want a JsonValue here without caring what type it is, so
let's just use get() instead.
This commit is contained in:
Sam Atkins 2025-09-26 15:16:49 +01:00 • committed by Andreas Kling
commit 11a6b6f38f
Notes: github-actions[bot] 2025-09-26 20:32:58 +00:00
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibDevTools/Actors/PageStyleActor.cpp
View file

@ -30,7 +30,7 @@ static void received_layout(JsonObject& response, JsonValue const& node_box_sizi
response.set(key, MUST(String::formatted("{}px", pixel_value(key))));
};
auto set_computed_value = [&](auto key) {
response.set(key, node_box_sizing.as_object().get_string(key).value_or(String {}));
response.set(key, node_box_sizing.as_object().get(key).value_or(String {}));
};
// FIXME: This response should also contain "top", "right", "bottom", and "left", but our box model metrics in