mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-04-27 23:09:08 +00:00
LibWeb: Cache intrinsic sizes across layout runs
This change moves intrinsic sizes cache from LayoutState, which is local to current layout run, to layout nodes, so it could be reused between layout runs. This optimization is possible because we can guarantee that these measurements will remain unchanged unless the style of the element or any of its descendants changes. For now, invalidation is implemented simply by resetting cache on whole ancestors chain once we figured that element needs layout update. The case when layout is invalidated by DOM's structural changes is covered by layout tree invalidation that drops intrinsic sizes cache along with layout nodes. I measured improvement on couple websites: - Mail list on GMail 28ms -> 6ms - GitHub large code page 47ms -> 36ms - Discord chat history 15ms -> 8ms (Time does not include `commit()`)
This commit is contained in:
parent
180a58b3d2
commit
12c6ac78e2
Notes:
github-actions[bot]
2025-03-08 10:46:30 +00:00
Author: https://github.com/kalenikaliaksandr
Commit: 12c6ac78e2
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/3851
13 changed files with 108 additions and 102 deletions
|
@ -762,7 +762,7 @@ void HTMLImageElement::add_callbacks_to_image_request(GC::Ref<ImageRequest> imag
|
|||
document().list_of_available_images().add(key, *image_data, true);
|
||||
|
||||
set_needs_style_update(true);
|
||||
document().set_needs_layout(DOM::SetNeedsLayoutReason::HTMLImageElementUpdateTheImageData);
|
||||
set_needs_layout_update(DOM::SetNeedsLayoutReason::HTMLImageElementUpdateTheImageData);
|
||||
|
||||
// 4. If maybe omit events is not set or previousURL is not equal to urlString, then fire an event named load at the img element.
|
||||
if (!maybe_omit_events || previous_url != url_string.serialize())
|
||||
|
@ -902,7 +902,7 @@ void HTMLImageElement::react_to_changes_in_the_environment()
|
|||
image_request->prepare_for_presentation(*this);
|
||||
// FIXME: This is ad-hoc, updating the layout here should probably be handled by prepare_for_presentation().
|
||||
set_needs_style_update(true);
|
||||
document().set_needs_layout(DOM::SetNeedsLayoutReason::HTMLImageElementReactToChangesInTheEnvironment);
|
||||
set_needs_layout_update(DOM::SetNeedsLayoutReason::HTMLImageElementReactToChangesInTheEnvironment);
|
||||
|
||||
// 7. Fire an event named load at the img element.
|
||||
dispatch_event(DOM::Event::create(realm(), HTML::EventNames::load));
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue