mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-16 05:51:55 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb: Serialize grid/grid-template as "none" when applicable

Browse source 
This exposes a bunch of false-positives in the
grid-{shorthand,template}-invalid.html WPT tests, but gains us some
new passes as well.
This commit is contained in:
Callum Law 2025-06-12 20:39:03 +12:00 • committed by Sam Atkins
parent 7d81823eb3
commit 12c9da2d3f
Notes: github-actions[bot] 2025-06-16 11:38:44 +00:00
7 changed files with 30 additions and 27 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Libraries/LibWeb/CSS/StyleValues/ShorthandStyleValue.cpp
View file

@ -383,6 +383,9 @@ String ShorthandStyleValue::to_string(SerializationMode mode) const
auto& rows = longhand(PropertyID::GridTemplateRows)->as_grid_track_size_list();
auto& columns = longhand(PropertyID::GridTemplateColumns)->as_grid_track_size_list();
if (areas.grid_template_area().size() == 0 && rows.grid_track_size_list().track_list().size() == 0 && columns.grid_track_size_list().track_list().size() == 0)
return "none"_string;
auto construct_rows_string = [&]() {
StringBuilder builder;
size_t idx = 0;