mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-07-28 19:59:17 +00:00
LibWeb: Serialize grid/grid-template as "none" when applicable
This exposes a bunch of false-positives in the
grid-{shorthand,template}-invalid.html WPT tests, but gains us some
new passes as well.
This commit is contained in:
Callum Law
Sam Atkins
parent
7d81823eb3
commit
12c9da2d3f
Notes:
github-actions[bot]
2025-06-16 11:38:44 +00:00
Author: https://github.com/Calme1709
Commit: 12c9da2d3f
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/5066
Reviewed-by: https://github.com/AtkinsSJ ✅
7 changed files with 30 additions and 27 deletions
|
|
@ -2,17 +2,17 @@ Harness status: OK
|
|||
|
||||
Found 34 tests
|
||||
|
||||
21 Pass
|
||||
13 Fail
|
||||
16 Pass
|
||||
18 Fail
|
||||
Pass e.style['grid'] = "none none" should not set the property value
|
||||
Pass e.style['grid'] = "none []" should not set the property value
|
||||
Fail e.style['grid'] = "10px" should not set the property value
|
||||
Fail e.style['grid'] = "20%" should not set the property value
|
||||
Fail e.style['grid'] = "5fr" should not set the property value
|
||||
Pass e.style['grid'] = "[a]" should not set the property value
|
||||
Fail e.style['grid'] = "[a]" should not set the property value
|
||||
Fail e.style['grid'] = "[a] 10px" should not set the property value
|
||||
Fail e.style['grid'] = "[a] 10px []" should not set the property value
|
||||
Pass e.style['grid'] = "[]" should not set the property value
|
||||
Fail e.style['grid'] = "[]" should not set the property value
|
||||
Fail e.style['grid'] = "10px \"a\"" should not set the property value
|
||||
Fail e.style['grid'] = "[] 10px \"a\"" should not set the property value
|
||||
Fail e.style['grid'] = "10px [] \"a\"" should not set the property value
|
||||
|
|
@ -28,13 +28,13 @@ Pass e.style['grid'] = "[a] \"a\" [a] [a]" should not set the property value
|
|||
Pass e.style['grid'] = "\"a\" \"a\" [a] [a]" should not set the property value
|
||||
Pass e.style['grid'] = "\"a\" [a] [a] / none" should not set the property value
|
||||
Pass e.style['grid'] = "\"a\" \"a\" [a] [a] / none" should not set the property value
|
||||
Pass e.style['grid'] = "none / \"a\"" should not set the property value
|
||||
Fail e.style['grid'] = "none / \"a\"" should not set the property value
|
||||
Pass e.style['grid'] = "\"a\" / none" should not set the property value
|
||||
Pass e.style['grid'] = "none / [] \"a\"" should not set the property value
|
||||
Fail e.style['grid'] = "none / [] \"a\"" should not set the property value
|
||||
Pass e.style['grid'] = "none / \"a\" []" should not set the property value
|
||||
Pass e.style['grid'] = "none / \"a\" [] 10px" should not set the property value
|
||||
Pass e.style['grid'] = "auto-flow 100px" should not set the property value
|
||||
Pass e.style['grid'] = "auto-flow / auto-flow" should not set the property value
|
||||
Fail e.style['grid'] = "auto-flow / auto-flow" should not set the property value
|
||||
Pass e.style['grid'] = "auto-flow 1fr / auto-flow 1fr" should not set the property value
|
||||
Pass e.style['grid'] = "dense auto-flow / dense auto-flow" should not set the property value
|
||||
Pass e.style['grid'] = "auto / auto-flow foo()" should not set the property value
|
||||
|
|
@ -2,10 +2,10 @@ Harness status: OK
|
|||
|
||||
Found 49 tests
|
||||
|
||||
5 Pass
|
||||
44 Fail
|
||||
Fail e.style['grid'] = "none" should set the property value
|
||||
Fail e.style['grid'] = "none / none" should set the property value
|
||||
7 Pass
|
||||
42 Fail
|
||||
Pass e.style['grid'] = "none" should set the property value
|
||||
Pass e.style['grid'] = "none / none" should set the property value
|
||||
Pass e.style['grid'] = "auto / auto" should set the property value
|
||||
Fail e.style['grid'] = "none / [a] 0px" should set the property value
|
||||
Fail e.style['grid'] = "none / [] 0px" should set the property value
|
||||
|
|
|
|||
|
|
@ -2,15 +2,15 @@ Harness status: OK
|
|||
|
||||
Found 66 tests
|
||||
|
||||
19 Pass
|
||||
47 Fail
|
||||
15 Pass
|
||||
51 Fail
|
||||
Fail e.style['grid-template'] = "auto" should not set the property value
|
||||
Pass e.style['grid-template'] = "none none" should not set the property value
|
||||
Pass e.style['grid-template'] = "none []" should not set the property value
|
||||
Fail e.style['grid-template'] = "10px" should not set the property value
|
||||
Fail e.style['grid-template'] = "20%" should not set the property value
|
||||
Fail e.style['grid-template'] = "5fr" should not set the property value
|
||||
Pass e.style['grid-template'] = "[a]" should not set the property value
|
||||
Fail e.style['grid-template'] = "[a]" should not set the property value
|
||||
Fail e.style['grid-template'] = "[a] 10px" should not set the property value
|
||||
Fail e.style['grid-template'] = "[a] repeat(2, 10px)" should not set the property value
|
||||
Fail e.style['grid-template'] = "[a] repeat(auto-fill, 10px)" should not set the property value
|
||||
|
|
@ -19,7 +19,7 @@ Fail e.style['grid-template'] = "[a] 10px []" should not set the property value
|
|||
Fail e.style['grid-template'] = "[a] repeat(2, 10px) []" should not set the property value
|
||||
Fail e.style['grid-template'] = "[a] repeat(auto-fill, 10px) []" should not set the property value
|
||||
Fail e.style['grid-template'] = "[a] repeat(auto-fit, 10px) []" should not set the property value
|
||||
Pass e.style['grid-template'] = "[]" should not set the property value
|
||||
Fail e.style['grid-template'] = "[]" should not set the property value
|
||||
Fail e.style['grid-template'] = "10px \"a\"" should not set the property value
|
||||
Fail e.style['grid-template'] = "repeat(2, 10px) \"a\"" should not set the property value
|
||||
Fail e.style['grid-template'] = "repeat(auto-fill, 10px) \"a\"" should not set the property value
|
||||
|
|
@ -62,9 +62,9 @@ Pass e.style['grid-template'] = "[a] \"a\" [a] [a]" should not set the property
|
|||
Pass e.style['grid-template'] = "\"a\" \"a\" [a] [a]" should not set the property value
|
||||
Pass e.style['grid-template'] = "\"a\" [a] [a] / none" should not set the property value
|
||||
Pass e.style['grid-template'] = "\"a\" \"a\" [a] [a] / none" should not set the property value
|
||||
Pass e.style['grid-template'] = "none / \"a\"" should not set the property value
|
||||
Fail e.style['grid-template'] = "none / \"a\"" should not set the property value
|
||||
Pass e.style['grid-template'] = "\"a\" / none" should not set the property value
|
||||
Pass e.style['grid-template'] = "none / [] \"a\"" should not set the property value
|
||||
Fail e.style['grid-template'] = "none / [] \"a\"" should not set the property value
|
||||
Pass e.style['grid-template'] = "none / \"a\" []" should not set the property value
|
||||
Pass e.style['grid-template'] = "none / \"a\" [] 10px" should not set the property value
|
||||
Pass e.style['grid-template'] = "none / \"a\" [] repeat(2, 10px)" should not set the property value
|
||||
|
|
|
|||
|
|
@ -2,10 +2,10 @@ Harness status: OK
|
|||
|
||||
Found 40 tests
|
||||
|
||||
5 Pass
|
||||
35 Fail
|
||||
Fail e.style['grid-template'] = "none" should set the property value
|
||||
Fail e.style['grid-template'] = "none / none" should set the property value
|
||||
7 Pass
|
||||
33 Fail
|
||||
Pass e.style['grid-template'] = "none" should set the property value
|
||||
Pass e.style['grid-template'] = "none / none" should set the property value
|
||||
Pass e.style['grid-template'] = "auto / auto" should set the property value
|
||||
Fail e.style['grid-template'] = "none / [a] 0px" should set the property value
|
||||
Fail e.style['grid-template'] = "none / [] 0px" should set the property value
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue