mirrors/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-04-21 12:05:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

WebContent: Plumb scroll-into-view requests from server to client

Browse source 
The WebContentView widget will now be able to react to scroll-into-view
requests from the WebContent process.
This commit is contained in:
Andreas Kling 2020-07-05 15:43:43 +02:00
parent 56d14d5701
commit 131bc8fd31
Notes: sideshowbarker 2024-07-19 05:08:22 +09:00
7 changed files with 22 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
Demos/WebView/WebContentClient.cpp
View file

@ -90,3 +90,11 @@ void WebContentClient::handle(const Messages::WebContentClient::DidChangeTitle&
#endif
m_view.notify_server_did_change_title({}, message.title());
}
void WebContentClient::handle(const Messages::WebContentClient::DidRequestScrollIntoView& message)
{
#ifdef DEBUG_SPAM
dbg() << "handle: WebContentClient::DidRequestScrollIntoView! rect=" << message.rect();
#endif
m_view.notify_server_did_request_scroll_into_view({}, message.rect());
}

1
Demos/WebView/WebContentClient.h
View file

@ -50,6 +50,7 @@ private:
virtual void handle(const Messages::WebContentClient::DidChangeSelection&) override;
virtual void handle(const Messages::WebContentClient::DidLayout&) override;
virtual void handle(const Messages::WebContentClient::DidChangeTitle&) override;
virtual void handle(const Messages::WebContentClient::DidRequestScrollIntoView&) override;
WebContentView& m_view;
};

5
Demos/WebView/WebContentView.cpp
View file

@ -115,6 +115,11 @@ void WebContentView::notify_server_did_change_title(Badge<WebContentClient>, con
on_title_change(title);
}
void WebContentView::notify_server_did_request_scroll_into_view(Badge<WebContentClient>, const Gfx::IntRect& rect)
{
scroll_into_view(rect, true, true);
}
void WebContentView::did_scroll()
{
client().post_message(Messages::WebContentServer::SetViewportRect(visible_content_rect()));

1
Demos/WebView/WebContentView.h
View file

@ -46,6 +46,7 @@ public:
void notify_server_did_invalidate_content_rect(Badge<WebContentClient>, const Gfx::IntRect&);
void notify_server_did_change_selection(Badge<WebContentClient>);
void notify_server_did_change_title(Badge<WebContentClient>, const String&);
void notify_server_did_request_scroll_into_view(Badge<WebContentClient>, const Gfx::IntRect&);
private:
WebContentView();

5
Services/WebContent/PageHost.cpp
View file

@ -129,4 +129,9 @@ void PageHost::page_did_change_title(const String& title)
m_client.post_message(Messages::WebContentClient::DidChangeTitle(title));
}
void PageHost::page_did_request_scroll_into_view(const Gfx::IntRect& rect)
{
m_client.post_message(Messages::WebContentClient::DidRequestScrollIntoView(rect));
}
}

1
Services/WebContent/PageHost.h
View file

@ -55,6 +55,7 @@ private:
virtual void page_did_change_selection() override;
virtual void page_did_layout() override;
virtual void page_did_change_title(const String&) override;
virtual void page_did_request_scroll_into_view(const Gfx::IntRect&) override;
explicit PageHost(ClientConnection&);

1
Services/WebContent/WebContentClient.ipc
View file

@ -6,4 +6,5 @@ endpoint WebContentClient = 90
DidChangeSelection() =|
DidLayout(Gfx::IntSize content_size) =|
DidChangeTitle(String title) =|
DidRequestScrollIntoView(Gfx::IntRect rect) =|
}