From 1369fc5069598644842defabbfbf3d30d2f3e647 Mon Sep 17 00:00:00 2001
From: Tim Ledbetter <tim.ledbetter@ladybird.org>
Date: Thu, 8 Aug 2024 10:35:57 +0100
Subject: [PATCH] LibWeb: Change attribute type to USVString where applicable

Also mark USVString attributes as containing a URL, where applicable.
---
 Tests/LibWeb/Text/expected/input-image.txt    |  2 +-
 .../expected/usvstring-url-reflection.txt     | 14 ++++++++++
 .../Text/expected/video-canceled-load.txt     |  2 +-
 .../Text/expected/video-failed-load.txt       |  2 +-
 Tests/LibWeb/Text/input/input-image.html      |  3 +-
 .../Text/input/usvstring-url-reflection.html  | 28 +++++++++++++++++++
 .../Text/input/video-canceled-load.html       |  2 +-
 .../LibWeb/HTML/HTMLAnchorElement.idl         |  2 +-
 .../LibWeb/HTML/HTMLEmbedElement.idl          |  2 +-
 .../LibWeb/HTML/HTMLFrameElement.idl          |  4 +--
 .../LibWeb/HTML/HTMLIFrameElement.idl         |  4 +--
 .../LibWeb/HTML/HTMLImageElement.idl          |  4 +--
 .../LibWeb/HTML/HTMLInputElement.idl          |  2 +-
 .../Libraries/LibWeb/HTML/HTMLLinkElement.idl |  4 +--
 .../LibWeb/HTML/HTMLMediaElement.idl          |  2 +-
 .../LibWeb/HTML/HTMLObjectElement.idl         |  4 +--
 .../LibWeb/HTML/HTMLScriptElement.idl         |  2 +-
 .../LibWeb/HTML/HTMLSourceElement.idl         |  4 +--
 .../LibWeb/HTML/HTMLTrackElement.idl          |  2 +-
 19 files changed, 66 insertions(+), 23 deletions(-)
 create mode 100644 Tests/LibWeb/Text/expected/usvstring-url-reflection.txt
 create mode 100644 Tests/LibWeb/Text/input/usvstring-url-reflection.html

diff --git a/Tests/LibWeb/Text/expected/input-image.txt b/Tests/LibWeb/Text/expected/input-image.txt
index e99c0ff6f4e..a10a8420ea3 100644
--- a/Tests/LibWeb/Text/expected/input-image.txt
+++ b/Tests/LibWeb/Text/expected/input-image.txt
@@ -1,2 +1,2 @@
-../../Layout/input/120.png loaded
+120.png loaded
 file:///i-do-no-exist-i-swear.png failed
diff --git a/Tests/LibWeb/Text/expected/usvstring-url-reflection.txt b/Tests/LibWeb/Text/expected/usvstring-url-reflection.txt
new file mode 100644
index 00000000000..f45cf42f7a1
--- /dev/null
+++ b/Tests/LibWeb/Text/expected/usvstring-url-reflection.txt
@@ -0,0 +1,14 @@
+audio.src final URL path segment: %EF%BF%BDa%EF%BF%BDb%EF%BF%BD
+embed.src final URL path segment: %EF%BF%BDa%EF%BF%BDb%EF%BF%BD
+frame.longDesc final URL path segment: %EF%BF%BDa%EF%BF%BDb%EF%BF%BD
+frame.src final URL path segment: %EF%BF%BDa%EF%BF%BDb%EF%BF%BD
+iframe.longDesc final URL path segment: %EF%BF%BDa%EF%BF%BDb%EF%BF%BD
+iframe.src final URL path segment: %EF%BF%BDa%EF%BF%BDb%EF%BF%BD
+img.src final URL path segment: %EF%BF%BDa%EF%BF%BDb%EF%BF%BD
+link.href final URL path segment: %EF%BF%BDa%EF%BF%BDb%EF%BF%BD
+object.codeBase final URL path segment: %EF%BF%BDa%EF%BF%BDb%EF%BF%BD
+object.data final URL path segment: %EF%BF%BDa%EF%BF%BDb%EF%BF%BD
+script.src final URL path segment: %EF%BF%BDa%EF%BF%BDb%EF%BF%BD
+source.src final URL path segment: %EF%BF%BDa%EF%BF%BDb%EF%BF%BD
+track.src final URL path segment: %EF%BF%BDa%EF%BF%BDb%EF%BF%BD
+video.src final URL path segment: %EF%BF%BDa%EF%BF%BDb%EF%BF%BD
diff --git a/Tests/LibWeb/Text/expected/video-canceled-load.txt b/Tests/LibWeb/Text/expected/video-canceled-load.txt
index 6d15bb54988..7adfb9174bd 100644
--- a/Tests/LibWeb/Text/expected/video-canceled-load.txt
+++ b/Tests/LibWeb/Text/expected/video-canceled-load.txt
@@ -1 +1 @@
- wfh
+ file:///example/file/location/wfh
diff --git a/Tests/LibWeb/Text/expected/video-failed-load.txt b/Tests/LibWeb/Text/expected/video-failed-load.txt
index 18af3d39d27..943960f61ce 100644
--- a/Tests/LibWeb/Text/expected/video-failed-load.txt
+++ b/Tests/LibWeb/Text/expected/video-failed-load.txt
@@ -1,3 +1,3 @@
 failed to load: "data:"
 failed to load: "file:///i-do-no-exist-i-swear"
-failed to load: "https://i-do-no-exist-i-swear.net.uk"
+failed to load: "https://i-do-no-exist-i-swear.net.uk/"
diff --git a/Tests/LibWeb/Text/input/input-image.html b/Tests/LibWeb/Text/input/input-image.html
index 96b8ed1bb3b..b7d0e405846 100644
--- a/Tests/LibWeb/Text/input/input-image.html
+++ b/Tests/LibWeb/Text/input/input-image.html
@@ -9,7 +9,8 @@
 
         return new Promise((resolve, reject) => {
             input.addEventListener("load", () => {
-                resolve(`${input.src} loaded`);
+                const filename = input.src.split('/').pop();
+                resolve(`${filename} loaded`);
             });
             input.addEventListener("error", () => {
                 resolve(`${input.src} failed`);
diff --git a/Tests/LibWeb/Text/input/usvstring-url-reflection.html b/Tests/LibWeb/Text/input/usvstring-url-reflection.html
new file mode 100644
index 00000000000..5c56481ded0
--- /dev/null
+++ b/Tests/LibWeb/Text/input/usvstring-url-reflection.html
@@ -0,0 +1,28 @@
+<!DOCTYPE html>
+<script src="include.js"></script>
+<script>
+    test(() => {
+        let elementList = [
+            { "audio": "src" },
+            { "embed": "src" },
+            { "frame": "longDesc" },
+            { "frame": "src" },
+            { "iframe": "longDesc" },
+            { "iframe": "src" },
+            { "img": "src" },
+            { "link": "href" },
+            { "object": "codeBase" },
+            { "object": "data" },
+            { "script": "src" },
+            { "source": "src" },
+            { "track": "src" },
+            { "video": "src" },
+        ];
+        for (const elementDescriptor of elementList) {
+            [elementName, propertyName] = Object.entries(elementDescriptor)[0];
+            const element = document.createElement(elementName);
+            element[propertyName] = "\udddda\uddddb\udddd";
+            println(`${elementName}.${propertyName} final URL path segment: ${element[propertyName].split("/").pop()}`);
+        }
+    });
+</script>
diff --git a/Tests/LibWeb/Text/input/video-canceled-load.html b/Tests/LibWeb/Text/input/video-canceled-load.html
index 2c1d94ee495..fd5aaa647d0 100644
--- a/Tests/LibWeb/Text/input/video-canceled-load.html
+++ b/Tests/LibWeb/Text/input/video-canceled-load.html
@@ -1,7 +1,7 @@
 <script src="include.js"></script>
 <script type="text/javascript">
     function updateSrc() {
-        video.src = "wfh";
+        video.src = "file:///example/file/location/wfh";
     }
 
     test(() => {
diff --git a/Userland/Libraries/LibWeb/HTML/HTMLAnchorElement.idl b/Userland/Libraries/LibWeb/HTML/HTMLAnchorElement.idl
index 17d2e6fbe4d..bac32dd50b4 100644
--- a/Userland/Libraries/LibWeb/HTML/HTMLAnchorElement.idl
+++ b/Userland/Libraries/LibWeb/HTML/HTMLAnchorElement.idl
@@ -10,7 +10,7 @@ interface HTMLAnchorElement : HTMLElement {
 
     [CEReactions, Reflect] attribute DOMString target;
     [CEReactions, Reflect] attribute DOMString download;
-    [CEReactions, Reflect] attribute DOMString ping;
+    [CEReactions, Reflect] attribute USVString ping;
     [CEReactions, Reflect] attribute DOMString rel;
     [SameObject, PutForwards=value] readonly attribute DOMTokenList relList;
     [CEReactions, Reflect] attribute DOMString hreflang;
diff --git a/Userland/Libraries/LibWeb/HTML/HTMLEmbedElement.idl b/Userland/Libraries/LibWeb/HTML/HTMLEmbedElement.idl
index ca00cb572db..03531eaf32e 100644
--- a/Userland/Libraries/LibWeb/HTML/HTMLEmbedElement.idl
+++ b/Userland/Libraries/LibWeb/HTML/HTMLEmbedElement.idl
@@ -6,7 +6,7 @@ interface HTMLEmbedElement : HTMLElement {
 
     [HTMLConstructor] constructor();
 
-    [CEReactions, Reflect] attribute DOMString src;
+    [CEReactions, Reflect, URL] attribute USVString src;
     [CEReactions, Reflect] attribute DOMString type;
     [CEReactions, Reflect] attribute DOMString width;
     [CEReactions, Reflect] attribute DOMString height;
diff --git a/Userland/Libraries/LibWeb/HTML/HTMLFrameElement.idl b/Userland/Libraries/LibWeb/HTML/HTMLFrameElement.idl
index 4cf2c5925ea..ec8ad5f190d 100644
--- a/Userland/Libraries/LibWeb/HTML/HTMLFrameElement.idl
+++ b/Userland/Libraries/LibWeb/HTML/HTMLFrameElement.idl
@@ -8,9 +8,9 @@ interface HTMLFrameElement : HTMLElement {
 
     [CEReactions, Reflect] attribute DOMString name;
     [CEReactions, Reflect] attribute DOMString scrolling;
-    [CEReactions, Reflect] attribute DOMString src;
+    [CEReactions, Reflect, URL] attribute USVString src;
     [CEReactions, Reflect=frameborder] attribute DOMString frameBorder;
-    [CEReactions, Reflect=longdesc] attribute DOMString longDesc;
+    [CEReactions, Reflect=longdesc, URL] attribute USVString longDesc;
     [CEReactions, Reflect=noresize] attribute boolean noResize;
     [FIXME] readonly attribute Document? contentDocument;
     [FIXME] readonly attribute WindowProxy? contentWindow;
diff --git a/Userland/Libraries/LibWeb/HTML/HTMLIFrameElement.idl b/Userland/Libraries/LibWeb/HTML/HTMLIFrameElement.idl
index 1f8b2451c47..205c4e7099e 100644
--- a/Userland/Libraries/LibWeb/HTML/HTMLIFrameElement.idl
+++ b/Userland/Libraries/LibWeb/HTML/HTMLIFrameElement.idl
@@ -8,7 +8,7 @@ interface HTMLIFrameElement : HTMLElement {
 
     [HTMLConstructor] constructor();
 
-    [CEReactions, Reflect] attribute DOMString src;
+    [CEReactions, Reflect, URL] attribute USVString src;
     [CEReactions, Reflect] attribute DOMString srcdoc;
     [CEReactions, Reflect] attribute DOMString name;
     [FIXME, SameObject, PutForwards=value] readonly attribute DOMTokenList sandbox;
@@ -26,7 +26,7 @@ interface HTMLIFrameElement : HTMLElement {
     [CEReactions, Reflect] attribute DOMString align;
     [CEReactions, Reflect] attribute DOMString scrolling;
     [CEReactions, Reflect=frameborder] attribute DOMString frameBorder;
-    [CEReactions, Reflect=longdesc] attribute USVString longDesc;
+    [CEReactions, Reflect=longdesc, URL] attribute USVString longDesc;
 
     [CEReactions, LegacyNullToEmptyString, Reflect=marginheight] attribute DOMString marginHeight;
     [CEReactions, LegacyNullToEmptyString, Reflect=marginwidth] attribute DOMString marginWidth;
diff --git a/Userland/Libraries/LibWeb/HTML/HTMLImageElement.idl b/Userland/Libraries/LibWeb/HTML/HTMLImageElement.idl
index 660920d6f4f..f00978a952c 100644
--- a/Userland/Libraries/LibWeb/HTML/HTMLImageElement.idl
+++ b/Userland/Libraries/LibWeb/HTML/HTMLImageElement.idl
@@ -9,7 +9,7 @@ interface HTMLImageElement : HTMLElement {
     [HTMLConstructor] constructor();
 
     [CEReactions, Reflect] attribute DOMString alt;
-    [CEReactions, Reflect] attribute DOMString src;
+    [CEReactions, Reflect, URL] attribute USVString src;
     [CEReactions, Reflect] attribute DOMString srcset;
     [CEReactions, Reflect] attribute DOMString sizes;
     [CEReactions, Enumerated=CORSSettingsAttribute, Reflect=crossorigin] attribute DOMString? crossOrigin;
@@ -34,7 +34,7 @@ interface HTMLImageElement : HTMLElement {
     [CEReactions, Reflect] attribute DOMString align;
     [CEReactions, Reflect] attribute unsigned long hspace;
     [CEReactions, Reflect] attribute unsigned long vspace;
-    [CEReactions, Reflect=longdesc] attribute USVString longDesc;
+    [CEReactions, Reflect=longdesc, URL] attribute USVString longDesc;
 
     [CEReactions, LegacyNullToEmptyString, Reflect] attribute DOMString border;
 
diff --git a/Userland/Libraries/LibWeb/HTML/HTMLInputElement.idl b/Userland/Libraries/LibWeb/HTML/HTMLInputElement.idl
index bf24aed35b2..c6ab07ab27c 100644
--- a/Userland/Libraries/LibWeb/HTML/HTMLInputElement.idl
+++ b/Userland/Libraries/LibWeb/HTML/HTMLInputElement.idl
@@ -36,7 +36,7 @@ interface HTMLInputElement : HTMLElement {
     [CEReactions, Reflect=readonly] attribute boolean readOnly;
     [CEReactions, Reflect] attribute boolean required;
     [CEReactions] attribute unsigned long size;
-    [CEReactions, Reflect] attribute DOMString src;
+    [CEReactions, Reflect] attribute USVString src;
     [CEReactions, Reflect] attribute DOMString step;
     [CEReactions] attribute DOMString type;
     [CEReactions, Reflect=value] attribute DOMString defaultValue;
diff --git a/Userland/Libraries/LibWeb/HTML/HTMLLinkElement.idl b/Userland/Libraries/LibWeb/HTML/HTMLLinkElement.idl
index 338c9983c68..990ba0de8bd 100644
--- a/Userland/Libraries/LibWeb/HTML/HTMLLinkElement.idl
+++ b/Userland/Libraries/LibWeb/HTML/HTMLLinkElement.idl
@@ -9,7 +9,7 @@ interface HTMLLinkElement : HTMLElement {
 
     [HTMLConstructor] constructor();
 
-    [CEReactions, Reflect] attribute DOMString href;
+    [CEReactions, Reflect, URL] attribute USVString href;
     [CEReactions, Reflect=crossorigin, Enumerated=CORSSettingsAttribute] attribute DOMString? crossOrigin;
     [CEReactions, Reflect] attribute DOMString rel;
     [CEReactions] attribute DOMString as;
@@ -19,7 +19,7 @@ interface HTMLLinkElement : HTMLElement {
     [CEReactions, Reflect] attribute DOMString hreflang;
     [CEReactions, Reflect] attribute DOMString type;
     [FIXME, SameObject, PutForwards=value] readonly attribute DOMTokenList sizes;
-    [CEReactions, Reflect=imagesrcset] attribute DOMString imageSrcset;
+    [CEReactions, Reflect=imagesrcset] attribute USVString imageSrcset;
     [CEReactions, Reflect=imagesizes] attribute DOMString imageSizes;
     [CEReactions, Reflect=referrerpolicy, Enumerated=ReferrerPolicy] attribute DOMString referrerPolicy;
     [FIXME, SameObject, PutForwards=value] readonly attribute DOMTokenList blocking;
diff --git a/Userland/Libraries/LibWeb/HTML/HTMLMediaElement.idl b/Userland/Libraries/LibWeb/HTML/HTMLMediaElement.idl
index 0fd13023485..8e1bde48900 100644
--- a/Userland/Libraries/LibWeb/HTML/HTMLMediaElement.idl
+++ b/Userland/Libraries/LibWeb/HTML/HTMLMediaElement.idl
@@ -30,7 +30,7 @@ interface HTMLMediaElement : HTMLElement {
     readonly attribute MediaError? error;
 
     // network state
-    [Reflect, CEReactions] attribute DOMString src;
+    [Reflect, CEReactions, URL] attribute USVString src;
     [FIXME] attribute MediaProvider? srcObject;
     readonly attribute USVString currentSrc;
     [Reflect=crossorigin, CEReactions, Enumerated=CORSSettingsAttribute] attribute DOMString? crossOrigin;
diff --git a/Userland/Libraries/LibWeb/HTML/HTMLObjectElement.idl b/Userland/Libraries/LibWeb/HTML/HTMLObjectElement.idl
index b3feda47f0d..cb0df5ba761 100644
--- a/Userland/Libraries/LibWeb/HTML/HTMLObjectElement.idl
+++ b/Userland/Libraries/LibWeb/HTML/HTMLObjectElement.idl
@@ -7,7 +7,7 @@ interface HTMLObjectElement : HTMLElement {
 
     [HTMLConstructor] constructor();
 
-    [CEReactions] attribute DOMString data;
+    [CEReactions, URL] attribute USVString data;
     [CEReactions, Reflect] attribute DOMString type;
     [CEReactions, Reflect] attribute DOMString name;
     readonly attribute HTMLFormElement? form;
@@ -32,7 +32,7 @@ interface HTMLObjectElement : HTMLElement {
     [CEReactions, Reflect] attribute unsigned long hspace;
     [CEReactions, Reflect] attribute DOMString standby;
     [CEReactions, Reflect] attribute unsigned long vspace;
-    [CEReactions, Reflect=codebase] attribute DOMString codeBase;
+    [CEReactions, Reflect=codebase, URL] attribute USVString codeBase;
     [CEReactions, Reflect=codetype] attribute DOMString codeType;
     [CEReactions, Reflect=usemap] attribute DOMString useMap;
 
diff --git a/Userland/Libraries/LibWeb/HTML/HTMLScriptElement.idl b/Userland/Libraries/LibWeb/HTML/HTMLScriptElement.idl
index a5370801c96..58d15b4480a 100644
--- a/Userland/Libraries/LibWeb/HTML/HTMLScriptElement.idl
+++ b/Userland/Libraries/LibWeb/HTML/HTMLScriptElement.idl
@@ -8,7 +8,7 @@ interface HTMLScriptElement : HTMLElement {
 
     [HTMLConstructor] constructor();
 
-    [CEReactions, Reflect] attribute DOMString src;
+    [CEReactions, Reflect, URL] attribute USVString src;
     [CEReactions, Reflect] attribute DOMString type;
     [CEReactions, Reflect=nomodule] attribute boolean noModule;
     [CEReactions] attribute boolean async;
diff --git a/Userland/Libraries/LibWeb/HTML/HTMLSourceElement.idl b/Userland/Libraries/LibWeb/HTML/HTMLSourceElement.idl
index 4379af016cc..b73fd6a4025 100644
--- a/Userland/Libraries/LibWeb/HTML/HTMLSourceElement.idl
+++ b/Userland/Libraries/LibWeb/HTML/HTMLSourceElement.idl
@@ -6,9 +6,9 @@ interface HTMLSourceElement : HTMLElement {
 
     [HTMLConstructor] constructor();
 
-    [CEReactions, Reflect] attribute DOMString src;
+    [CEReactions, Reflect, URL] attribute USVString src;
     [CEReactions, Reflect] attribute DOMString type;
-    [CEReactions, Reflect] attribute DOMString srcset;
+    [CEReactions, Reflect] attribute USVString srcset;
     [CEReactions, Reflect] attribute DOMString sizes;
     [CEReactions, Reflect] attribute DOMString media;
     [CEReactions, Reflect] attribute unsigned long width;
diff --git a/Userland/Libraries/LibWeb/HTML/HTMLTrackElement.idl b/Userland/Libraries/LibWeb/HTML/HTMLTrackElement.idl
index bd4533df98e..945b2501a81 100644
--- a/Userland/Libraries/LibWeb/HTML/HTMLTrackElement.idl
+++ b/Userland/Libraries/LibWeb/HTML/HTMLTrackElement.idl
@@ -17,7 +17,7 @@ interface HTMLTrackElement : HTMLElement {
     [HTMLConstructor] constructor();
 
     [CEReactions, Enumerated=TrackKindAttribute, Reflect] attribute DOMString kind;
-    [CEReactions, Reflect] attribute DOMString src;
+    [CEReactions, Reflect, URL] attribute USVString src;
     [CEReactions, Reflect] attribute DOMString srclang;
     [CEReactions, Reflect] attribute DOMString label;
     [CEReactions, Reflect] attribute boolean default;