AK+LibUnicode: Implement String::equals_ignoring_case without allocating

We currently fully casefold the left- and right-hand sides to compare two strings with case-insensitivity. Now, we casefold one code point at a time, storing the result in a view for comparison, until we exhaust both strings.
Author: https://github.com/trflynn89 Commit: 1393ed2000 Pull-request: https://github.com/SerenityOS/serenity/pull/17769 Reviewed-by: https://github.com/Hendiadyoin1 Reviewed-by: https://github.com/linusg ✅
2025-07-31 21:29:06 +00:00 · 2023-03-08 13:03:04 -05:00 · 2023-03-08 13:03:04 -05:00 · 1393ed2000 · 2024-07-17 07:16:27 +09:00
commit 1393ed2000
parent 4aee4e80bd
6 changed files with 150 additions and 52 deletions
--- a/Userland/Libraries/LibJS/Runtime/Intl/AbstractOperations.cpp
+++ b/Userland/Libraries/LibJS/Runtime/Intl/AbstractOperations.cpp
@ -29,7 +29,7 @@ ThrowCompletionOr<Optional<::Locale::LocaleID>> is_structurally_valid_language_t
        quick_sort(variants);

        for (size_t i = 0; i < variants.size() - 1; ++i) {
-            if (TRY_OR_THROW_OOM(vm, variants[i].equals_ignoring_case(variants[i + 1])))
+            if (variants[i].equals_ignoring_case(variants[i + 1]))
                return true;
        }