From 14ae04075e2911af7d24c9ca328c2ce22a38bb61 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=B6nke=20Holz?= Date: Sat, 4 May 2024 13:00:35 +0200 Subject: [PATCH] LibDebug: Make LineProgram::create take DwarfInfo as a const reference The m_dwarf_info is never mutated, so it can be const. --- Userland/Libraries/LibDebug/Dwarf/LineProgram.cpp | 4 ++-- Userland/Libraries/LibDebug/Dwarf/LineProgram.h | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/Userland/Libraries/LibDebug/Dwarf/LineProgram.cpp b/Userland/Libraries/LibDebug/Dwarf/LineProgram.cpp index c95c56a19e9..68b97f0b7db 100644 --- a/Userland/Libraries/LibDebug/Dwarf/LineProgram.cpp +++ b/Userland/Libraries/LibDebug/Dwarf/LineProgram.cpp @@ -13,13 +13,13 @@ namespace Debug::Dwarf { -LineProgram::LineProgram(DwarfInfo& dwarf_info, size_t unit_offset) +LineProgram::LineProgram(DwarfInfo const& dwarf_info, size_t unit_offset) : m_dwarf_info(dwarf_info) , m_unit_offset(unit_offset) { } -ErrorOr> LineProgram::create(DwarfInfo& dwarf_info, SeekableStream& stream) +ErrorOr> LineProgram::create(DwarfInfo const& dwarf_info, SeekableStream& stream) { auto offset = TRY(stream.tell()); auto program = TRY(adopt_nonnull_own_or_enomem(new (nothrow) LineProgram(dwarf_info, offset))); diff --git a/Userland/Libraries/LibDebug/Dwarf/LineProgram.h b/Userland/Libraries/LibDebug/Dwarf/LineProgram.h index e1467a1023a..e30cbba3180 100644 --- a/Userland/Libraries/LibDebug/Dwarf/LineProgram.h +++ b/Userland/Libraries/LibDebug/Dwarf/LineProgram.h @@ -109,7 +109,7 @@ class LineProgram { AK_MAKE_NONMOVABLE(LineProgram); public: - static ErrorOr> create(DwarfInfo& dwarf_info, SeekableStream& stream); + static ErrorOr> create(DwarfInfo const& dwarf_info, SeekableStream& stream); struct LineInfo { FlatPtr address { 0 }; @@ -134,7 +134,7 @@ public: bool looks_like_embedded_resource() const; private: - LineProgram(DwarfInfo& dwarf_info, size_t unit_offset); + LineProgram(DwarfInfo const& dwarf_info, size_t unit_offset); ErrorOr parse_unit_header(SeekableStream& stream); ErrorOr parse_source_directories(SeekableStream& stream); @@ -175,7 +175,7 @@ private: static constexpr u16 MIN_DWARF_VERSION = 3; static constexpr u16 MAX_DWARF_VERSION = 5; - DwarfInfo& m_dwarf_info; + DwarfInfo const& m_dwarf_info; size_t m_unit_offset { 0 }; LineProgramUnitHeader32 m_unit_header {};