mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-04-22 20:45:14 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb: Add missing calls to Base::children_changed

Browse source 
Also making sure that it is called at the top of the implementation
for consistency.
This commit is contained in:
Shannon Booth 2025-01-26 13:49:39 +13:00 • committed by Tim Ledbetter
parent 22a7cd9700
commit 14eb081af8
Notes: github-actions[bot] 2025-01-27 00:11:37 +00:00
5 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibWeb/HTML/HTMLMediaElement.cpp
View file

@ -768,6 +768,8 @@ GC_DEFINE_ALLOCATOR(SourceElementSelector);
void HTMLMediaElement::children_changed()
{
Base::children_changed();
if (m_source_element_selector)
m_source_element_selector->process_next_candidate().release_value_but_fixme_should_propagate_errors();
}

2
Libraries/LibWeb/HTML/HTMLScriptElement.cpp
View file

@ -574,6 +574,8 @@ void HTMLScriptElement::prepare_script()
// https://html.spec.whatwg.org/multipage/scripting.html#script-processing-model:html-element-post-connection-steps-4
void HTMLScriptElement::children_changed()
{
Base::children_changed();
// 1. Run the script HTML element post-connection steps, given the script element.
post_connection();
}

2
Libraries/LibWeb/HTML/HTMLStyleElement.cpp
View file

@ -34,8 +34,8 @@ void HTMLStyleElement::visit_edges(Cell::Visitor& visitor)
void HTMLStyleElement::children_changed()
{
m_style_element_utils.update_a_style_block(*this);
Base::children_changed();
m_style_element_utils.update_a_style_block(*this);
}
void HTMLStyleElement::inserted()

2
Libraries/LibWeb/HTML/HTMLTextAreaElement.cpp
View file

@ -431,6 +431,8 @@ void HTMLTextAreaElement::update_placeholder_visibility()
// https://html.spec.whatwg.org/multipage/form-elements.html#the-textarea-element:children-changed-steps
void HTMLTextAreaElement::children_changed()
{
Base::children_changed();
// The children changed steps for textarea elements must, if the element's dirty value flag is false,
// set the element's raw value to its child text content.
if (!m_dirty_value) {

2
Libraries/LibWeb/SVG/SVGStyleElement.cpp
View file

@ -32,8 +32,8 @@ void SVGStyleElement::visit_edges(Cell::Visitor& visitor)
void SVGStyleElement::children_changed()
{
m_style_element_utils.update_a_style_block(*this);
Base::children_changed();
m_style_element_utils.update_a_style_block(*this);
}
void SVGStyleElement::inserted()