mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-29 04:09:13 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Form the correct representation of a WebDriver element reference

Browse source 
We are currently returning a JSON object of the form:

    {
        "name": "element-6066-11e4-a52e-4f735466cecf",
        "value": "foo"
    }

Instead, we are expected to return an object of the form:

    {
        "element-6066-11e4-a52e-4f735466cecf": "foo"
    }
This commit is contained in:
Timothy Flynn 2024-09-26 15:01:29 -04:00 • committed by Tim Ledbetter
commit 157d41bb0d
Notes: github-actions[bot] 2024-09-27 08:47:55 +00:00
3 changed files with 10 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Services/WebContent/WebDriverConnection.cpp
View file

@ -550,7 +550,7 @@ Messages::WebDriverClient::SwitchToFrameResponse WebDriverConnection::switch_to_
// -> id represents a web element
else if (id.is_object()) {
auto element_id = id.as_object().get_byte_string("value"sv).release_value();
auto element_id = Web::WebDriver::extract_web_element_reference(id.as_object());
// 1. If session's current browsing context is no longer open, return error with error code no such window.
TRY(ensure_current_browsing_context_is_open());