mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-10-05 07:39:16 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Correctly round non-integer z-indexes

Browse source 
Previously we would just cast to an int.

Gains us 3 WPT tests.
This commit is contained in:
Callum Law 2025-08-01 15:07:07 +12:00 • committed by Tim Ledbetter
commit 15cee5cc15
Notes: github-actions[bot] 2025-08-05 05:39:02 +00:00
3 changed files with 73 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Libraries/LibWeb/CSS/ComputedProperties.cpp
View file

@ -338,7 +338,7 @@ Optional<int> ComputedProperties::z_index() const
return {};
// Clamp z-index to the range of a signed 32-bit integer for consistency with other engines.
auto clamp = [](auto number) -> int {
auto clamp = [](long number) -> int {
if (number >= NumericLimits<int>::max())
return NumericLimits<int>::max();
if (number <= NumericLimits<int>::min())
@ -352,7 +352,8 @@ Optional<int> ComputedProperties::z_index() const
if (value.is_calculated()) {
auto maybe_double = value.as_calculated().resolve_number_deprecated({});
if (maybe_double.has_value()) {
return clamp(maybe_double.value());
// Round up on half
return clamp(floor(maybe_double.value() + 0.5f));
}
}
return {};